← Back to team overview

kicad-developers team mailing list archive

Re: 3D-Viewer - Request for merge evaluation

 

I forgot to mention most of you copyright date are 2015.  Any files
modified in 2016 needs to be corrected.

On 6/28/2016 2:52 PM, Mário Luzeiro wrote:
> Hi Wayne,
> 
> From the email below, I took your advice about the camel case and underscores naming and updated my branch,
> renaming variables and some function names, to apply to that policy.
> 
> https://code.launchpad.net/~mrluzeiro/kicad/kicad_new3d-viewer
> 
> I didn't received any more reports related with freezes or crashes.
> I am not planning at moment any addition, I will just keep it updated with main branch.
> 
> Regards,
> Mario Luzeiro
> ________________________________________
> From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx] on behalf of Wayne Stambaugh [stambaughw@xxxxxxxxx]
> Sent: 27 June 2016 19:40
> To: kicad-developers@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Kicad-developers] [PATCH 03/16] Clarify ERC: we're iterating netlist items, not nets
> 
> This patch and patches 0005 and 0006 of this patch set do not apply
> cleanly.  Please rebase and resubmit them when you get a chance.  FYI,
> the coding policy frowns upon mixing camel case and underscores.  I know
> there are cases of this in the code but they are most likely left over
> from before the coding policy was implemented.  Please rename
> lastItem_idx to lastItemIdx or last_item_idx.  The same goes for
> nextItem_idx.
> 
> Thanks,
> 
> Wayne
> 


References