← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Rewrite loop conditions in SchematicCleanUp

 

I really need to start reading my email more carefully.

On 6/29/2016 11:36 AM, Wayne Stambaugh wrote:
> Sorry about the confusion.  This patch was an attachment but your rebase
                                                              ^^ Simon's
> of replacing boost::shared_ptr with std::shared_ptr patch was not so I
> just wanted to make sure your updated boost FOREACH patch was an attachment.
                          ^^ Simon's
> 
> On 6/29/2016 11:34 AM, Chris Pavlina wrote:
>> That is an attachment, I think you need a better mail client. ;)
>>
>> On Wed, Jun 29, 2016 at 11:29:56AM -0400, Wayne Stambaugh wrote:
>>> Simon,
>>>
>>> This patch needs rebased as well.  Please include the patch as an
>>> attachment rather than inline.  Bazaar doesn't play as nicely with
>>> inline mail merges as git does.
>>>
>>> Thanks,
>>>
>>> Wayne
>>>
>>> On 6/21/2016 11:26 AM, Simon Richter wrote:
>>>>
>>>> These are a tiny bit more readable, and do not depend on all branches to
>>>> correctly advance the loop variable.
>>>> ---
>>>>  eeschema/sch_screen.cpp | 27 +++++++--------------------
>>>>  1 file changed, 7 insertions(+), 20 deletions(-)
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp


References