← Back to team overview

kicad-developers team mailing list archive

Re: 3D-Viewer - Request for merge evaluation

 

I've actually stopped building it because I couldn't find any more real issues
and it was becoming a hassle to manage the separate branch... yeah, definitely
time to merge.

On Fri, Jul 15, 2016 at 01:35:07PM -0400, Wayne Stambaugh wrote:
> One last call for known issues and/or objections before I merge this
> code into the product branch.
> 
> On 7/3/2016 8:15 AM, Mário Luzeiro wrote:
> > Hi Chris,
> > 
> > Thanks to some kind of divine help, somehow it looks to be solved and in addition looks to be safe/free from crashes.
> > 
> > Would you like to test it again and as a sort of validation, try to test it with as many boards as possible ?
> > Pay attention on the zones generation or any forms created using polygons and see if you find any issue.
> > 
> > Regards,
> > Mario Luzeiro
> > ________________________________________
> > From: Mário Luzeiro
> > Sent: 02 July 2016 21:46
> > To: Chris Pavlina
> > Cc: Wayne Stambaugh; kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Subject: RE: [Kicad-developers] 3D-Viewer - Request for merge evaluation
> > 
> > Good find Chris,
> > 
> > That is an issue related with the triangulation library "Poly2Tri"
> > It may not be a bug with the library it self, but as it has very restrictive data inputs, there could be some data that is making it not happy.
> > I will investigate how can I fix the polygon..
> > 
> > Mario
> > ________________________________________
> > From: Chris Pavlina [pavlina.chris@xxxxxxxxx]
> > Sent: 02 July 2016 19:17
> > To: Mário Luzeiro
> > Cc: Wayne Stambaugh; kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
> > 
> > Got a bug for you. On rev 6132, the linked [1] board file reproducibly gives
> > the artifact shown [2] in both OpenGL and raytracer. Master branch has no
> > artifact.
> > 
> > [1] https://misc.c4757p.com/new3d_trouble.kicad_pcb
> > [2] https://misc.c4757p.com/new3d_artifact.png
> > 
> 


Follow ups

References