kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Hi Michael,

Good job, I know it was not trivial. I have just tested the patch
against the same boost versions under Linux and it works as expected.
Thank you for the fix, it has been committed in revision 7002.

Regards,
Orson

On 08/02/2016 02:26 AM, Michael Steinberg wrote:
> Hello all,
> 
> attached is v2 of the crash fix. My original patch would move the
> function out of the transition before a copy of it could be pushed to
> the state stack.
> 
> The second patch refactors coroutine, mostly for clarification and
> correctness purposes. A few documentation hints were added. It also
> removes many unnecessary heap allocations of single pointers. I compiled
> and tested it with boost 1.54, 1.60 and 1.61. Compile- and runtime-tests
> on these and other boost versions would be very welcome, this stuff is
> very brittle! I'm almost at a point having the tree duplicated for every
> boost version, for not having to recompile kicad completely when
> switching them...
> 
> Michael
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature