kicad-developers team mailing list archive

Thread
Date

Re: Broken setlocale in sim/ngspice.cpp

To: jp charras <jp.charras@xxxxxxxxxx>, KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
From: Maciej Sumiński <maciej.suminski@xxxxxxx>
Date: Mon, 15 Aug 2016 15:53:35 +0200
Authentication-results: spf=pass (sender IP is 188.184.36.50) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
In-reply-to: <93b24460-fde3-992f-836a-d5c1849fd7f5@wanadoo.fr>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 08/15/2016 03:03 PM, jp charras wrote:
> The reason is setlocale( LC_ALL, "" ); switches the locale to the system locale, not the previously
> set locale.
> It creates serious issues if the previous locale or the Kicad locale is not the system locale.
> (For instance if you are using inside Kicad an other language than the default)
> 
> It creates serious issues especially when the system fp separator is the comma instead of the point.
> Usually the floating point validators in dialogs become broken and fp values can be no more entered.
> And these issues are not easy to fix (I spent time to understand what happened and to fix that issue)

Hi Jean-Pierre,

Understood, thank you for the notice. I have fixed the code in revision
7036.

Regards,
Orson

Attachment: signature.asc
Description: OpenPGP digital signature

References

Broken setlocale in sim/ngspice.cpp
From: jp charras, 2016-08-15