← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] A few small changes to CMake and the compiling instructions

 

Yes

2016-09-04 23:01 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> So I have this straight:
>
> John's 0002 and 0003 patches
> Nick's 0001, 0002, and 0003 patches
>
> Is this correct?
>
> On 9/3/2016 5:09 PM, Nick Østergaard wrote:
>> I just made my changes in multiple patches such that they are easy to
>> review, they should probably be squashed with the commit description
>> if committed.
>>
>> 2016-09-03 23:05 GMT+02:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
>>> I also prepared some patches to address this issue with the switch,
>>> but I did not submit them, because no one commented further on it.
>>>
>>> But for the git descriptions, why do you suggest "-b master" for the
>>> git clone, that should not be necessary.
>>>
>>> My patches replaces the 0001 patch of Jon's, they also add the
>>> preprocessor define and adds it to the version information. Also it
>>> adds a description for the new eeschema IO manager stuff. Please
>>> reveiw the description I made.
>>>
>>> 2016-09-03 22:28 GMT+02:00 Jon Neal <reportingsjr@xxxxxxxxx>:
>>>> 0001 changes the USE_OCE flag to KICAD_USE_OCE as discussed.
>>>> 0002 adds libngspice and OCE to the INSTALL.txt dependencies list and
>>>> removes a dead link
>>>> 0003 updates compiling.md to remove bzr references and adds info about the
>>>> KICAD_USE_OCE flag
>>>>
>>>> Jon
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References