kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #26041
Re: [PATCH] A few small changes to CMake and the compiling instructions
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Sun, 4 Sep 2016 18:59:00 -0400
-
In-reply-to:
<CAOuK9Lh4z7jXxxy6nELpYVu2=rr+hLmp8THoxN1yvJKcJOXEHg@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
If I'm going to go through the trouble to squash them, why not just
squash them on your end and just send me a single patch and I can just
use git am?
On 9/3/2016 5:09 PM, Nick Østergaard wrote:
> I just made my changes in multiple patches such that they are easy to
> review, they should probably be squashed with the commit description
> if committed.
>
> 2016-09-03 23:05 GMT+02:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
>> I also prepared some patches to address this issue with the switch,
>> but I did not submit them, because no one commented further on it.
>>
>> But for the git descriptions, why do you suggest "-b master" for the
>> git clone, that should not be necessary.
>>
>> My patches replaces the 0001 patch of Jon's, they also add the
>> preprocessor define and adds it to the version information. Also it
>> adds a description for the new eeschema IO manager stuff. Please
>> reveiw the description I made.
>>
>> 2016-09-03 22:28 GMT+02:00 Jon Neal <reportingsjr@xxxxxxxxx>:
>>> 0001 changes the USE_OCE flag to KICAD_USE_OCE as discussed.
>>> 0002 adds libngspice and OCE to the INSTALL.txt dependencies list and
>>> removes a dead link
>>> 0003 updates compiling.md to remove bzr references and adds info about the
>>> KICAD_USE_OCE flag
>>>
>>> Jon
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help : https://help.launchpad.net/ListHelp
>>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References