← Back to team overview

kicad-developers team mailing list archive

[PATCH] add missing parentheses in page layout templates

 

The default and logo page layout templates are missing some opening
parentheses. Eeschema's parser accepts them anyway, but it tripped
my s-expr parser.

The gost templates and the built-in default in
common/page_layout/page_layout_default_description.cpp
are both correct.

- Werner
commit c4a3b851729b4e1727221bc73d8ace642ebcb3b6
Author: Werner Almesberger <werner@xxxxxxxxxxxxxxx>
Date:   Thu Sep 8 15:37:33 2016 -0300

    template/pagelayout_{default,logo}.kicad_wks: add missing opening parentheses

diff --git a/template/pagelayout_default.kicad_wks b/template/pagelayout_default.kicad_wks
index 60c1973..a839593 100644
--- a/template/pagelayout_default.kicad_wks
+++ b/template/pagelayout_default.kicad_wks
@@ -13,22 +13,22 @@
     ( tbtext "A" (pos 1 25 rtcorner) (font (size 1.3 1.3))
         (justify center) (repeat 100) (incry 50) )
     ( tbtext "Date: %D" (pos 87 6.9) )
-    ( line (start 110 5.5) end 2 5.5) )
+    ( line (start 110 5.5) (end 2 5.5) )
     ( tbtext "%K" (pos 109 4.1) (comment "Kicad version" ) )
-    ( line (start 110 8.5) end 2 8.5) )
+    ( line (start 110 8.5) (end 2 8.5) )
     ( tbtext "Rev: %R" (pos 24 6.9)(font bold)(justify left) )
     ( tbtext "Size: %Z" (comment "Paper format name")(pos 109 6.9) )
     ( tbtext "Id: %S/%N" (comment "Sheet id")(pos 24 4.1) )
-    ( line (start 110 12.5) end 2 12.5) )
+    ( line (start 110 12.5) (end 2 12.5) )
     ( tbtext "Title: %T" (pos 109 10.7)(font bold (size 2 2)) )
     ( tbtext "File: %F" (pos 109 14.3) )
-    ( line (start 110 18.5) end 2 18.5) )
+    ( line (start 110 18.5) (end 2 18.5) )
     ( tbtext "Sheet: %P" (pos 109 17) )
     ( tbtext "%Y" (comment "Company name") (pos 109 20)(font bold) )
     ( tbtext "%C0" (comment "Comment 0") (pos 109 23) )
     ( tbtext "%C1" (comment "Comment 1") (pos 109 26) )
     ( tbtext "%C2" (comment "Comment 2") (pos 109 29) )
     ( tbtext "%C3" (comment "Comment 3") (pos 109 32) )
-    ( line (start 90 8.5) end 90 5.5) )
-    ( line (start 26 8.5) end 26 2) )
+    ( line (start 90 8.5) (end 90 5.5) )
+    ( line (start 26 8.5) (end 26 2) )
 )
diff --git a/template/pagelayout_logo.kicad_wks b/template/pagelayout_logo.kicad_wks
index dd71096..c2bb6b5 100644
--- a/template/pagelayout_logo.kicad_wks
+++ b/template/pagelayout_logo.kicad_wks
@@ -13,16 +13,16 @@
     ( tbtext "A" (pos 1 25 rtcorner) (font (size 1.3 1.3))
         (justify center) (repeat 100) (incry 50) )
     ( tbtext "Date: %D" (pos 87 6.9) )
-    ( line (start 110 5.5) end 2 5.5) )
+    ( line (start 110 5.5) (end 2 5.5) )
     ( tbtext "%K" (pos 109 4.1) (comment "Kicad version" ) )
-    ( line (start 110 8.5) end 2 8.5) )
+    ( line (start 110 8.5) (end 2 8.5) )
     ( tbtext "Rev: %R" (pos 24 6.9)(font bold)(justify left) )
     ( tbtext "Size: %Z" (comment "Paper format name")(pos 109 6.9) )
     ( tbtext "Id: %S/%N" (comment "Sheet id")(pos 24 4.1) )
-    ( line (start 110 12.5) end 2 12.5) )
+    ( line (start 110 12.5) (end 2 12.5) )
     ( tbtext "Title: %T" (pos 109 10.7)(font bold (size 2 2)) )
     ( tbtext "File: %F" (pos 109 14.3) )
-    ( line (start 110 18.5) end 2 18.5) )
+    ( line (start 110 18.5) (end 2 18.5) )
     ( tbtext "Sheet: %P" (pos 109 17) )
     ( tbtext "%Y" (comment "Company name") (pos 109 20)(font bold) )
     ( tbtext "%C0" (comment "Comment 0") (pos 109 23) )

Follow ups