kicad-developers team mailing list archive

[Ian Roth <imr2107@xxxxxxxxxxxx>]

The change looks good. I think it is ready to be pushed.

On Sat, Sep 10, 2016 at 2:10 PM, Chris Pavlina <pavlina.chris@xxxxxxxxx>
wrote:

> Only one more comment, but a small one so I fixed it for you. I've
> attached a fixup diff against yours, please let me know that you are
> okay with the changes made to your patch and I'll push it.
>
> 1. The phrase "Multiple Layers" must be translateable so that it will
> display in the language of the current locale.
>
> 2. I bumped the copyright year to 2016 on the files you edited.
>
> Thank you for your contribution!
>
>
> On Sat, Sep 10, 2016 at 01:51:13PM -0400, Ian Roth wrote:
> > Attached is an updated patch. The need for this is that at the place
> that I
> > work, we are to document all board layouts. I use the print function in
> > pcbnew, and select 1 layer per page since the documentation is to be in
> > black and white. This works great, except that there is no way to flip
> to a
> > page and know what layer you are looking at unless you are already
> familiar
> > with the board. This patch makes looking over the documentation easier
> > since the layer name, ie. F.Cu, B.Cu et cetera is printed in the
> worksheet.
> >
> > Please feel free to ask any additional questions.
> >
> > Ian
> >
> > On Sat, Sep 10, 2016 at 8:15 AM, Chris Pavlina <pavlina.chris@xxxxxxxxx>
> > wrote:
> >
> > > What it says on the tin. It adds a %L format string to labels in the
> > > worksheet (title block) that will contain the layer name when printed.
> > >
> > > I like this, but I agree with Wayne - having to edit so many files
> > > because of how the layer name is being passed in is just not good.
> > > Having that many function parameters in general can get irritating and
> > > confusing.
> > >
> > > On Sat, Sep 10, 2016 at 02:02:01PM +0200, Nick Østergaard wrote:
> > > > I have not tried this patch, but could you be a bit more descriptive
> of
> > > > what this patch do for the user and why?
> > > >
> > > > Den 08/09/2016 17.09 skrev "Ian Roth" <imr2107@xxxxxxxxxxxx>:
> > > >
> > > > > This patch allows for printing layer names in pcbnew using a %L
> > > formater.
> > > > > This is helpful when printing 1 layer per page.
> > > > >
> > > > > Ian
> > > > >
> > > > > _______________________________________________
> > > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > > More help   : https://help.launchpad.net/ListHelp
> > > > >
> > > > >
> > >
> > >
>
>