← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Remove assert in pcbnew on osx with a debug build

 

Hi Simon,

Can you give more details about the assert? Perhaps it is a different
problem and should be solved in another way.

wxWidgets documentation[1] says it is necessary to create a wxPaintDC
object, even if it is not used. IIRC GAL worked on every platform even
when it has not created wxPaintDC object, but if the documentation says
it should be there, I would rather follow the advice.

Regards,
Orson

1. http://docs.wxwidgets.org/stable/classwx_paint_d_c.html

On 09/18/2016 06:32 AM, Simon Wells wrote:
> ---
>  common/draw_panel_gal.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/common/draw_panel_gal.cpp b/common/draw_panel_gal.cpp
> index fd48d83..2616490 100644
> --- a/common/draw_panel_gal.cpp
> +++ b/common/draw_panel_gal.cpp
> @@ -156,7 +156,9 @@ void EDA_DRAW_PANEL_GAL::SetFocus()
>  void EDA_DRAW_PANEL_GAL::onPaint( wxPaintEvent& WXUNUSED( aEvent ) )
>  {
>      // This is required even though dc is not used otherwise.
> +#ifndef __WXMAC__
>      wxPaintDC dc(this);
> +#endif
>  
>      m_pendingRefresh = false;
>  
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References