kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

JP,

Since you do most if not all of the bitmap maintenance, please apply the
patches in this patch set that make sense and discard anything that
doesn't work for you.

Thanks,

Wayne

On 9/21/2016 6:32 AM, jp charras wrote:
> Le 21/09/2016 à 00:21, Niki Guldbrand a écrit :
>>
>> * Move the generated PNG and temporary files to the build tree, but
>>   keep the generated c files in the source tree for easier
>>   addition/updates in tree.
>> * Syncronize .gitignore to the changes.
>>
>> Signed-off-by: Niki Guldbrand <niki.guldbrand@xxxxxxxxx>
>> ---
>>  .gitignore                 | 2 --
>>  bitmaps_png/CMakeLists.txt | 5 ++---
>>  2 files changed, 2 insertions(+), 5 deletions(-)
>>
> 
> I agree for temporary files.
> 
> I fully disagree to move generated PNG files to the build tree.
> 
> As a icon maintainer and a menu/toolbar maintainer, I am very *happy* to easily find them in source
> tree, for instance when I want to create a new icon, or choose an existing icon for a new menu item.
> 
> Build tree is subject to be deleted, not files in source tree.
>