kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 21/09/2016 à 19:33, Niki Guldbrand a écrit :
> On ons, 2016-09-21 at 12:32 +0200, jp charras wrote:
>> Le 21/09/2016 à 00:21, Niki Guldbrand a écrit :
>>>
>>>
>>> * Move the generated PNG and temporary files to the build tree, but
>>>   keep the generated c files in the source tree for easier
>>>   addition/updates in tree.
>>> * Syncronize .gitignore to the changes.
>>>
>>> Signed-off-by: Niki Guldbrand <niki.guldbrand@xxxxxxxxx>
>>> ---
>>>  .gitignore                 | 2 --
>>>  bitmaps_png/CMakeLists.txt | 5 ++---
>>>  2 files changed, 2 insertions(+), 5 deletions(-)
>>>
>>
>> I agree for temporary files.
>>
>> I fully disagree to move generated PNG files to the build tree.
>>
>> As a icon maintainer and a menu/toolbar maintainer, I am very *happy*
>> to easily find them in source
>> tree, for instance when I want to create a new icon, or choose an
>> existing icon for a new menu item.
>>
>> Build tree is subject to be deleted, not files in source tree.
>>
> Well they are still available, you just have to look in the build tree
> instead, so in my view it's a none issue, as they will be recreated if
> needed.
> 
> And you still have the source files avalible (svg), to look at.

Are you joking?
There are near 500 icons.

Only png files can be displayed as images when exploring a folder, not svg files.

Moreover I wrote:
"Build tree is subject to be deleted, not files in source tree."
Clearly, you not read me.

> I was even considering removing the 'if( MAINTAIN_PNGS ) all together,
> and replace it with something that lookes if the cpp file was older
> than the svg, and in that case regenerate the cpp file and not keep the
> png's around.

Forget it.

> 
> I'm also considering moving the svg's to the resources folder, because
> they are resources, and not source files, but that may just be my view.
> 

The current tree was designed by guys who know what they are doing, not beginners.
It can be modified, but with good reasons.

svg files are sources, like html or .fbp files
Why some guys are thinking only cpp files are sources. This is false.
Sources files can be written in any language (svg *is* a language)

Clearly you have never maintained icon files.
Maintain is not just build file: it is most of time create, choose and edit files.

Still, I am in the impression you did not really read my previous mail.

-- 
Jean-Pierre CHARRAS