kicad-developers team mailing list archive

[Simon Wells <swel024@xxxxxxxxx>]

i am getting the following warning

/Users/simon/kicad-app/kicad/pcbnew/exporters/export_vrml.cpp:1624:18: warning:
      comparison of constant -1 with expression of type 'VRML_COLOR_INDEX' is
      always false [-Wtautological-constant-out-of-range-compare]

    if( colorIdx == -1 )
        ~~~~~~~~ ^  ~~

the enum is specified as

enum VRML_COLOR_INDEX
{
    VRML_COLOR_PCB = 0,
    VRML_COLOR_TRACK,
    VRML_COLOR_SILK,
    VRML_COLOR_TIN,
    VRML_COLOR_LAST
};

as the expression is if (colorIdx == -1 ) colorIdx = VRML_COLOR_PCB
would it not be worth adding a value for -1 into the enum (not sure
whether it should be VRML_COLOR_AUTO or VRML_COLOR_UNSPECIFIED)

thanks

Simon