← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 2/2] Warn about missing override specifiers, if supported (gcc 5.1, clang 3.5)

 

Le 25/09/2016 à 20:54, Simon Wells a écrit :
> my mistake if you add SYSTEM to line 15 of
> plugins/3d/oce/CMakeLists.txt it should shut up any oce warnings
> 
> include_directories( SYSTEM
>     ${OCE_INCLUDE_DIRS}
> )

Yes, it works. Thanks.

It is also needed in kicad2step.

> 
> On Mon, Sep 26, 2016 at 7:51 AM, Simon Wells <swel024@xxxxxxxxx> wrote:
>> This is whats annoying with projects that provide their own cmake
>> files and do the include & lib stuff without just passing it back in a
>> variable, If it was just returned in a variable we could just mark OCE
>> as system, however as thats not the case a patch may need to be made
>> and pushed upstream to OCE marking the include as system
>>
>> On Mon, Sep 26, 2016 at 7:45 AM, jp charras <jp.charras@xxxxxxxxxx> wrote:
>>> Le 25/09/2016 à 20:01, Wayne Stambaugh a écrit :
>>>> Simon,
>>>>
>>>> I pushed you patches.  Thanks.  It would be nice to have a way to either
>>>> turn off -Wsuggest-override when building the python scripting or figure
>>>> out how to tell swig define methods as overridden in the generated
>>>> files.  Otherwise, there are bunch of warnings when building the python
>>>> scripting support which I'm sure someone will grumble about.  If you
>>>> could provide a solution for this, it would be greatly appreciated.
>>>>
>>>> Thanks,
>>>>
>>>> Wayne
>>>
>>> I also have a lot of warnings with OCE headers.
>>>
>>>
>>> --
>>> Jean-Pierre CHARRAS
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
> 


-- 
Jean-Pierre CHARRAS


References