kicad-developers team mailing list archive

[Simon Wells <swel024@xxxxxxxxx>]

ok i will update my patch to #ifdef it out then

thanks

On Mon, Sep 26, 2016 at 9:41 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> AFAIR, it is #ifdef'd out in the other apps.
>
> On 9/25/2016 4:39 PM, Simon Wells wrote:
>> i guess the function could be #ifdef'd out to osx as its not used by
>> any other platform, unless anyone has a better/cleaner suggestion
>>
>> On Mon, Sep 26, 2016 at 9:30 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>> Simon,
>>>
>>> I getting the following build error on windows with this patch:
>>>
>>> E:/msys64/home/Wayne/src/kicad-lp-clone/common/single_top.cpp:195:10:
>>> error: 'void APP_SINGLE_TOP::MacOpenFile(const wxString&)' marked
>>> 'override', but does not override
>>>      void MacOpenFile( const wxString& aFileName ) override
>>>           ^~~~~~~~~~~
>>> make[2]: ***
>>> [bitmap2component/CMakeFiles/bitmap2component.dir/build.make:67:
>>> bitmap2component/CMakeFiles/bitmap2component.dir/__/common/single_top.cpp.obj]
>>> Error 1
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>> On 9/25/2016 3:20 PM, Simon Wells wrote:
>>>> ---
>>>>  common/single_top.cpp | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>