kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

I figured you had the commit covered. :)

On 9/26/2016 3:40 PM, Chris Pavlina wrote:
> Please don't commit this for me, I forgot to update copyright date on
> the files I modified. I'll do it later tonight.
> 
> 
> On Sep 26, 2016 2:49 PM, "Wayne Stambaugh" <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     On 9/26/2016 2:08 PM, Chris Pavlina wrote:
>     > On Mon, Sep 26, 2016 at 01:59:11PM -0400, Wayne Stambaugh wrote:
>     >> On 9/26/2016 1:29 PM, Chris Pavlina wrote:
>     >>> Hi,
>     >>>
>     >>> Since we seem to have (mostly) agreed that the red bikeshed is okay,
>     >>> here's a patch to fix up the window titles. I didn't just rip out
>     >>> version numbers, I went through and rewrote them all to use
>     mostly the
>     >>> same format (as they're currently rather inconsistent). The new
>     format
>     >>> is "Application — file", with variants as necessary
>     ("Application — file
>     >>> [Read Only]", "Application — sheet [sheetpath] — file", etc).
>     >>>
>     >>> There is one 'interesting' place: eeschema/backanno.cpp:236
>     >>>
>     >>>
>     https://github.com/KiCad/kicad-source-mirror/blob/master/eeschema/backanno.cpp#L236
>     <https://github.com/KiCad/kicad-source-mirror/blob/master/eeschema/backanno.cpp#L236>
>     >>>
>     >>> I have no idea why we would want to put the .cmp file name in the
>     >>> eeschema title bar in the first place, and furthermore couldn't
>     actually
>     >>> find a case where it wasn't immediately overwritten anyway. Not sure
>     >>> why that's even there - I ripped it out. Let me know if anyone knows
>     >>> what that's actually for...
>     >>
>     >> That is odd.  Typically externally loaded file names are displayed in
>     >> the message panel not on the title bar.  I'm OK with removing it
>     >> although displaying it on the message panel would give the user some
>     >> feedback.
>     >
>     > Okay. If you're fine with the rest, then this should be ready for
>     commit
>     > - adding the .cmp file to the message panel should probably be
>     done in a
>     > separate commit if we do that.
> 
>     That's fine by me.
> 
>     >
>     > Personally I don't think it's necessary, though - this is done right
>     > after showing the user a file-select dialog. Is it really necessary to
>     > tell the user what they just selected?
> 
>     Probably not since the user will get an error dialog if the file fails
>     to load properly.  I can live without it.
> 
>     >
>     >>
>     >>>
>     >>>
>     >>>
>     >>> _______________________________________________
>     >>> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >>> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >>>
>     >>
>     >> _______________________________________________
>     >> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>