kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hey Simon,

Thanks for the update.  I agree that we should not default to oldest
supported.  Let me know when you have an answer.

Cheers,

Wayne

On 10/12/2016 12:51 PM, Simon Wells wrote:
> Hi Wayne,
> 
> I will need to relook at this and see where i got up to and whether i
> was able to finish it off.. The whole idea behind it though is not to
> remove the ability to provide own paths but to be more sane with the
> defaults..... It shouldn't be treating the "oldest supported" as the
> "preferred" version which is what the script currently does
> 
> On Thu, Oct 13, 2016 at 3:22 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>> Simon,
>>
>> I've been going through my patch backlog and ran into this one.  Is this
>> patch still relevant?
>>
>> Thanks,
>>
>> Wayne
>>
>> On 5/20/2016 6:50 PM, Simon Wells wrote:
>>> heres the patch
>>>
>>> On Sat, May 21, 2016 at 10:49 AM, Simon Wells <swel024@xxxxxxxxx> wrote:
>>>> Please find attached updated patch that removes
>>>> CMakeModules/CMakeFindFrameworks.cmake
>>>>
>>>> Adam if you can test the patch it would be useful
>>>>
>>>> but based on when that file was last changed (in 2013) and is the same
>>>> in the ubuntu 14.04 cmake 2.8.12 distribution  as it is in 3.5 which i
>>>> use i don't think it should be an issue at all
>>>>
>>>> Simon
>>>>
>>>> On Thu, May 19, 2016 at 6:40 PM, Simon Wells <swel024@xxxxxxxxx> wrote:
>>>>> Included are updated FindPython cmake modules, Using the current
>>>>> FindPython*.cmake files with the mingw modifications from in tree. I
>>>>> have been unable to test the mingw versions as i do not have a mingw
>>>>> environment set up
>>>>>
>>>>> The reason i have updated these as currently the scripts first looks
>>>>> for the version thats specified, aka FindPythonInterp 2.6 will prefer
>>>>> version 2.6 to 2.7 so if both are installed then it requires
>>>>> specifying. The new script i believe first checks the system python.
>>>>> Again i am not sure if this will break mingw but i think it would be
>>>>> better to modify the new version regardless.
>>>>>
>>>>> As part of this would it be better if we only included a
>>>>> FindPythonInterp for mingw as it seems we only need the customisation
>>>>> for mingw and we are losing the ability to just use updated scripts
>>>>> for other operating systems
>>>>>
>>>>> Simon
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp