kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #26638
Re: [PATCH 00/14] RFC: Events in Dialogs
Simon,
What version of wxFB are you using to generate the changes?
Thanks,
Wayne
On 10/12/2016 1:49 PM, Simon Richter wrote:
> Hi,
>
> I've stumbled over a few events that are not actually used anymore, so I've
> looked for a way to find these. The easiest way seems to be to make event
> handlers pure virtual functions and see which derived dialogs actually
> override the functions.
>
> For most dialogs, that is straightforward, as there is a 1:1 mapping of
> generated base and concrete dialog class. Here I could remove a few
> handlers easily.
>
> There are 8 changes that need manual inspection:
>
> - 3 places where we use a generated dialog class directly. The generated
> class requests to be notified on close, but doesn't handle the event,
> while the derived class (HTML_MESSAGE_BOX) has the usual EndModal()
> stuff. This smells.
>
> - One typo where a derived class did not actually override an event
> handler, and no one noticed so far.
>
> - A variant where a button isn't always shown in a dialog, and the derived
> class needs to know to either provide a handler or hide the button.
>
> - A confused inheritance tree where we call TransferDataToWindow()
> explicitly.
>
> I'm fairly sure that isn't an exhaustive list of problems.
>
> These patches are not yet tested for functionality, so they shouldn't be
> applied directly. I'm fairly sure the removal of the unused events is
> correct (these are the cases where the only deriving class didn't override
> the default "{ event.Skip(); }" implementation), but these definitely need
> to be inspected by someone who actually knows what they are doing.
>
> The patches prefixed "CHECK" are definitely just hints at a class of
> problems we might to look for further.
>
> Simon
>
> Simon Richter (14):
> wxFormBuilder: convert empty strings
> wxFormBuilder: update older schema files
> Remove version number from wxFB output
> wxFormBuilder: regenerate all dialogs
> wxFormBuilder: Remove unused events
> CHECK: use HTML_MESSAGE_BOX instead of base
> CHECK: use HTML_MESSAGE_BOX instead of base
> CHECK: use HTML_MESSAGE_BOX instead of base
> CHECK: fix typo
> CHECK: Explicitly handle events for hidden button
> CHECK: Does any variant need to handle Close events?
> CHECK: Fully handle event in derived class.
> CHECK: does any dialog in the family need this?
> wxFormBuilder: pure virtual event handlers
>
> .../3d_cache/dialogs/dlg_3d_pathconfig_base.cpp | 2 +-
> .../3d_cache/dialogs/dlg_3d_pathconfig_base.fbp | 2 +-
> .../3d_cache/dialogs/dlg_3d_pathconfig_base.h | 14 +-
> .../dialogs/dialog_3D_view_option_base.cpp | 4 +-
> .../dialogs/dialog_3D_view_option_base.fbp | 4 +-
> .../3d_viewer/dialogs/dialog_3D_view_option_base.h | 9 +-
> bitmap2component/bitmap2cmp_gui_base.cpp | 36 +-
> bitmap2component/bitmap2cmp_gui_base.fbp | 9 +-
> bitmap2component/bitmap2cmp_gui_base.h | 18 +-
> common/class_marker_base.cpp | 4 +-
> common/dialog_about/dialog_about_base.cpp | 2 +-
> common/dialog_about/dialog_about_base.fbp | 2 +-
> common/dialog_about/dialog_about_base.h | 2 +-
> common/dialogs/dialog_display_info_HTML_base.cpp | 4 +-
> common/dialogs/dialog_display_info_HTML_base.fbp | 296 ++--
> common/dialogs/dialog_display_info_HTML_base.h | 5 +-
> common/dialogs/dialog_env_var_config_base.cpp | 2 +-
> common/dialogs/dialog_env_var_config_base.fbp | 2 +-
> common/dialogs/dialog_env_var_config_base.h | 8 +-
> common/dialogs/dialog_exit_base.cpp | 2 +-
> common/dialogs/dialog_exit_base.fbp | 2 +-
> common/dialogs/dialog_exit_base.h | 6 +-
> common/dialogs/dialog_get_component_base.cpp | 3 +-
> common/dialogs/dialog_get_component_base.fbp | 2 +-
> common/dialogs/dialog_get_component_base.h | 8 +-
> common/dialogs/dialog_hotkeys_editor_base.cpp | 2 +-
> common/dialogs/dialog_hotkeys_editor_base.fbp | 2 +-
> common/dialogs/dialog_hotkeys_editor_base.h | 6 +-
> common/dialogs/dialog_image_editor.fbp | 1054 +++++++-------
> common/dialogs/dialog_image_editor_base.cpp | 7 +-
> common/dialogs/dialog_image_editor_base.h | 22 +-
> common/dialogs/dialog_list_selector_base.cpp | 2 +-
> common/dialogs/dialog_list_selector_base.h | 2 +-
> common/dialogs/dialog_page_settings_base.cpp | 30 +-
> common/dialogs/dialog_page_settings_base.fbp | 4 +-
> common/dialogs/dialog_page_settings_base.h | 33 +-
> common/dialogs/wx_html_report_panel_base.cpp | 2 +-
> common/dialogs/wx_html_report_panel_base.fbp | 2 +-
> common/dialogs/wx_html_report_panel_base.h | 14 +-
> cvpcb/dialogs/dialog_config_equfiles_base.cpp | 2 +-
> cvpcb/dialogs/dialog_config_equfiles_base.fbp | 2 +-
> cvpcb/dialogs/dialog_config_equfiles_base.h | 16 +-
> cvpcb/dialogs/dialog_cvpcb_config_fbp.h | 2 +-
> cvpcb/dialogs/dialog_display_options_base.cpp | 2 +-
> cvpcb/dialogs/dialog_display_options_base.fbp | 2 +-
> cvpcb/dialogs/dialog_display_options_base.h | 8 +-
> .../fp_conflict_assignment_selector_base.cpp | 2 +-
> .../fp_conflict_assignment_selector_base.fbp | 2 +-
> .../dialogs/fp_conflict_assignment_selector_base.h | 12 +-
> eeschema/dialogs/dialog_annotate_base.cpp | 2 +-
> eeschema/dialogs/dialog_annotate_base.fbp | 2 +-
> eeschema/dialogs/dialog_annotate_base.h | 8 +-
> eeschema/dialogs/dialog_bom_base.cpp | 2 +-
> eeschema/dialogs/dialog_bom_base.fbp | 2 +-
> eeschema/dialogs/dialog_bom_base.h | 22 +-
> eeschema/dialogs/dialog_choose_component_base.cpp | 2 +-
> eeschema/dialogs/dialog_choose_component_base.fbp | 2 +-
> eeschema/dialogs/dialog_choose_component_base.h | 20 +-
> .../dialogs/dialog_edit_component_in_lib_base.cpp | 5 +-
> .../dialogs/dialog_edit_component_in_lib_base.fbp | 2 +-
> .../dialogs/dialog_edit_component_in_lib_base.h | 24 +-
> .../dialog_edit_component_in_schematic_fbp.cpp | 207 +--
> .../dialog_edit_component_in_schematic_fbp.fbp | 2 +-
> .../dialog_edit_component_in_schematic_fbp.h | 44 +-
> eeschema/dialogs/dialog_edit_label_base.cpp | 2 +-
> eeschema/dialogs/dialog_edit_label_base.fbp | 2 +-
> eeschema/dialogs/dialog_edit_label_base.h | 8 +-
> .../dialog_edit_libentry_fields_in_lib_base.cpp | 11 +-
> .../dialog_edit_libentry_fields_in_lib_base.fbp | 2 +-
> .../dialog_edit_libentry_fields_in_lib_base.h | 22 +-
> eeschema/dialogs/dialog_eeschema_config_fbp.cpp | 6 +-
> eeschema/dialogs/dialog_eeschema_config_fbp.fbp | 6 +-
> eeschema/dialogs/dialog_eeschema_config_fbp.h | 21 +-
> eeschema/dialogs/dialog_eeschema_options_base.cpp | 4 +-
> eeschema/dialogs/dialog_eeschema_options_base.fbp | 6 +-
> eeschema/dialogs/dialog_eeschema_options_base.h | 10 +-
> eeschema/dialogs/dialog_erc_base.cpp | 2 +-
> eeschema/dialogs/dialog_erc_base.fbp | 2 +-
> eeschema/dialogs/dialog_erc_base.h | 16 +-
> eeschema/dialogs/dialog_lib_edit_draw_item.fbp | 2 +-
> .../dialogs/dialog_lib_edit_draw_item_base.cpp | 2 +-
> eeschema/dialogs/dialog_lib_edit_draw_item_base.h | 2 +-
> eeschema/dialogs/dialog_lib_edit_pin_base.cpp | 7 +-
> eeschema/dialogs/dialog_lib_edit_pin_base.fbp | 2 +-
> eeschema/dialogs/dialog_lib_edit_pin_base.h | 14 +-
> .../dialogs/dialog_lib_edit_pin_table_base.cpp | 6 +-
> eeschema/dialogs/dialog_lib_edit_pin_table_base.h | 2 +-
> eeschema/dialogs/dialog_lib_edit_text.cpp | 7 +
> eeschema/dialogs/dialog_lib_edit_text.h | 2 +
> eeschema/dialogs/dialog_lib_edit_text_base.cpp | 2 +-
> eeschema/dialogs/dialog_lib_edit_text_base.fbp | 2 +-
> eeschema/dialogs/dialog_lib_edit_text_base.h | 10 +-
> eeschema/dialogs/dialog_lib_new_component.fbp | 2 +-
> eeschema/dialogs/dialog_lib_new_component_base.cpp | 2 +-
> eeschema/dialogs/dialog_lib_new_component_base.h | 2 +-
> eeschema/dialogs/dialog_libedit_options_base.cpp | 2 +-
> eeschema/dialogs/dialog_libedit_options_base.fbp | 2 +-
> eeschema/dialogs/dialog_libedit_options_base.h | 2 +-
> eeschema/dialogs/dialog_netlist_base.cpp | 4 +-
> eeschema/dialogs/dialog_netlist_base.fbp | 8 +-
> eeschema/dialogs/dialog_netlist_base.h | 18 +-
> eeschema/dialogs/dialog_plot_schematic_base.cpp | 9 +-
> eeschema/dialogs/dialog_plot_schematic_base.fbp | 9 +-
> eeschema/dialogs/dialog_plot_schematic_base.h | 14 +-
> .../dialogs/dialog_print_using_printer_base.cpp | 2 +-
> .../dialogs/dialog_print_using_printer_base.fbp | 2 +-
> eeschema/dialogs/dialog_print_using_printer_base.h | 12 +-
> eeschema/dialogs/dialog_rescue_each.cpp | 10 +-
> eeschema/dialogs/dialog_rescue_each_base.cpp | 4 +-
> eeschema/dialogs/dialog_rescue_each_base.fbp | 4 +-
> eeschema/dialogs/dialog_rescue_each_base.h | 13 +-
> .../dialogs/dialog_sch_edit_sheet_pin_base.cpp | 5 +-
> .../dialogs/dialog_sch_edit_sheet_pin_base.fbp | 2 +-
> eeschema/dialogs/dialog_sch_edit_sheet_pin_base.h | 2 +-
> eeschema/dialogs/dialog_sch_sheet_props.fbp | 2 +-
> eeschema/dialogs/dialog_sch_sheet_props_base.cpp | 6 +-
> eeschema/dialogs/dialog_sch_sheet_props_base.h | 2 +-
> eeschema/dialogs/dialog_schematic_find_base.cpp | 6 +-
> eeschema/dialogs/dialog_schematic_find_base.fbp | 6 +-
> eeschema/dialogs/dialog_schematic_find_base.h | 21 +-
> eeschema/dialogs/dialog_signal_list_base.cpp | 2 +-
> eeschema/dialogs/dialog_signal_list_base.fbp | 2 +-
> eeschema/dialogs/dialog_signal_list_base.h | 4 +-
> eeschema/dialogs/dialog_sim_settings_base.cpp | 2 +-
> eeschema/dialogs/dialog_sim_settings_base.fbp | 2 +-
> eeschema/dialogs/dialog_sim_settings_base.h | 6 +-
> eeschema/dialogs/dialog_spice_model_base.cpp | 2 +-
> eeschema/dialogs/dialog_spice_model_base.fbp | 2 +-
> eeschema/dialogs/dialog_spice_model_base.h | 26 +-
> eeschema/pinedit.cpp | 4 +-
> eeschema/sim/sim_plot_frame_base.cpp | 2 +-
> eeschema/sim/sim_plot_frame_base.fbp | 2 +-
> eeschema/sim/sim_plot_frame_base.h | 36 +-
> eeschema/widgets/tuner_slider_base.cpp | 2 +-
> eeschema/widgets/tuner_slider_base.fbp | 2 +-
> eeschema/widgets/tuner_slider_base.h | 14 +-
> .../dialogs/dialog_layers_select_to_pcb_base.cpp | 2 +-
> .../dialogs/dialog_layers_select_to_pcb_base.fbp | 2 +-
> .../dialogs/dialog_layers_select_to_pcb_base.h | 12 +-
> .../dialogs/dialog_print_using_printer_base.cpp | 2 +-
> .../dialogs/dialog_print_using_printer_base.fbp | 2 +-
> gerbview/dialogs/dialog_print_using_printer_base.h | 14 +-
> gerbview/dialogs/dialog_show_page_borders_base.cpp | 2 +-
> gerbview/dialogs/dialog_show_page_borders_base.fbp | 6 +-
> gerbview/dialogs/dialog_show_page_borders_base.h | 8 +-
> .../gerbview_dialog_display_options_frame_base.cpp | 2 +-
> .../gerbview_dialog_display_options_frame_base.fbp | 2 +-
> .../gerbview_dialog_display_options_frame_base.h | 6 +-
> kicad/dialogs/dialog_template_selector.fbp | 6 +-
> kicad/dialogs/dialog_template_selector_base.cpp | 2 +-
> kicad/dialogs/dialog_template_selector_base.h | 10 +-
> new/sweet_editor_panel.cpp | 2 +-
> new/sweet_editor_panel.h | 2 +-
> .../dialogs/dialog_new_dataitem_base.cpp | 2 +-
> .../dialogs/dialog_new_dataitem_base.fbp | 2 +-
> .../dialogs/dialog_new_dataitem_base.h | 6 +-
> .../dialogs/properties_frame_base.cpp | 476 +++----
> .../dialogs/properties_frame_base.fbp | 2 +-
> pagelayout_editor/dialogs/properties_frame_base.h | 22 +-
> pcb_calculator/dialogs/dialog_regulator_data.fbp | 2 +-
> .../dialogs/dialog_regulator_data_base.cpp | 2 +-
> .../dialogs/dialog_regulator_data_base.h | 6 +-
> .../dialogs/pcb_calculator_frame_base.cpp | 2 +-
> .../dialogs/pcb_calculator_frame_base.fbp | 10 +-
> pcb_calculator/dialogs/pcb_calculator_frame_base.h | 54 +-
> pcbnew/dialogs/dialog_SVG_print_base.cpp | 2 +-
> pcbnew/dialogs/dialog_SVG_print_base.fbp | 2 +-
> pcbnew/dialogs/dialog_SVG_print_base.h | 10 +-
> pcbnew/dialogs/dialog_block_options_base.cpp | 22 +-
> pcbnew/dialogs/dialog_block_options_base.fbp | 2 +-
> pcbnew/dialogs/dialog_block_options_base.h | 8 +-
> pcbnew/dialogs/dialog_cleaning_options_base.cpp | 2 +-
> pcbnew/dialogs/dialog_cleaning_options_base.fbp | 2 +-
> pcbnew/dialogs/dialog_cleaning_options_base.h | 2 +-
> pcbnew/dialogs/dialog_copper_zones_base.cpp | 2 +-
> pcbnew/dialogs/dialog_copper_zones_base.fbp | 2 +-
> pcbnew/dialogs/dialog_copper_zones_base.h | 18 +-
> pcbnew/dialogs/dialog_create_array_base.cpp | 4 +-
> pcbnew/dialogs/dialog_create_array_base.fbp | 4 +-
> pcbnew/dialogs/dialog_create_array_base.h | 7 +-
> pcbnew/dialogs/dialog_design_rules_base.cpp | 23 +-
> pcbnew/dialogs/dialog_design_rules_base.fbp | 2 +-
> pcbnew/dialogs/dialog_design_rules_base.h | 26 +-
> pcbnew/dialogs/dialog_dimension_editor_base.cpp | 2 +-
> pcbnew/dialogs/dialog_dimension_editor_base.fbp | 2 +-
> pcbnew/dialogs/dialog_dimension_editor_base.h | 4 +-
> pcbnew/dialogs/dialog_display_options_base.cpp | 2 +-
> pcbnew/dialogs/dialog_display_options_base.fbp | 2 +-
> pcbnew/dialogs/dialog_display_options_base.h | 6 +-
> pcbnew/dialogs/dialog_drc_base.cpp | 2 +-
> pcbnew/dialogs/dialog_drc_base.fbp | 2 +-
> pcbnew/dialogs/dialog_drc_base.h | 34 +-
> .../dialog_edit_module_for_BoardEditor_base.cpp | 2 +-
> .../dialog_edit_module_for_BoardEditor_base.fbp | 2 +-
> .../dialog_edit_module_for_BoardEditor_base.h | 24 +-
> .../dialog_edit_module_for_Modedit_base.cpp | 2 +-
> .../dialog_edit_module_for_Modedit_base.fbp | 2 +-
> .../dialogs/dialog_edit_module_for_Modedit_base.h | 22 +-
> pcbnew/dialogs/dialog_edit_module_text_base.cpp | 4 +-
> pcbnew/dialogs/dialog_edit_module_text_base.fbp | 4 +-
> pcbnew/dialogs/dialog_edit_module_text_base.h | 7 +-
> pcbnew/dialogs/dialog_enum_pads_base.cpp | 11 +-
> pcbnew/dialogs/dialog_enum_pads_base.fbp | 2 +-
> pcbnew/dialogs/dialog_enum_pads_base.h | 2 +-
> pcbnew/dialogs/dialog_exchange_modules_base.cpp | 5 +-
> pcbnew/dialogs/dialog_exchange_modules_base.fbp | 2 +-
> pcbnew/dialogs/dialog_exchange_modules_base.h | 14 +-
> pcbnew/dialogs/dialog_export_idf_base.cpp | 2 +-
> pcbnew/dialogs/dialog_export_idf_base.fbp | 2 +-
> pcbnew/dialogs/dialog_export_idf_base.h | 2 +-
> pcbnew/dialogs/dialog_export_step_base.cpp | 2 +-
> pcbnew/dialogs/dialog_export_step_base.fbp | 2 +-
> pcbnew/dialogs/dialog_export_step_base.h | 2 +-
> pcbnew/dialogs/dialog_export_vrml_base.cpp | 21 +-
> pcbnew/dialogs/dialog_export_vrml_base.fbp | 2 +-
> pcbnew/dialogs/dialog_export_vrml_base.h | 4 +-
> pcbnew/dialogs/dialog_find_base.cpp | 26 +-
> pcbnew/dialogs/dialog_find_base.fbp | 702 +++++-----
> pcbnew/dialogs/dialog_find_base.h | 12 +-
> .../dialogs/dialog_footprint_wizard_list_base.cpp | 2 +-
> .../dialogs/dialog_footprint_wizard_list_base.fbp | 2 +-
> pcbnew/dialogs/dialog_footprint_wizard_list_base.h | 4 +-
> pcbnew/dialogs/dialog_fp_lib_table_base.cpp | 18 +-
> pcbnew/dialogs/dialog_fp_lib_table_base.h | 2 +-
> pcbnew/dialogs/dialog_fp_plugin_options_base.cpp | 20 +-
> pcbnew/dialogs/dialog_fp_plugin_options_base.h | 2 +-
> pcbnew/dialogs/dialog_freeroute_exchange.cpp | 4 +-
> pcbnew/dialogs/dialog_freeroute_exchange_base.cpp | 2 +-
> pcbnew/dialogs/dialog_freeroute_exchange_base.fbp | 2 +-
> pcbnew/dialogs/dialog_freeroute_exchange_base.h | 10 +-
> .../dialog_gen_module_position_file_base.cpp | 2 +-
> .../dialog_gen_module_position_file_base.fbp | 2 +-
> .../dialogs/dialog_gen_module_position_file_base.h | 6 +-
> pcbnew/dialogs/dialog_gendrill_base.cpp | 7 +-
> pcbnew/dialogs/dialog_gendrill_base.fbp | 2 +-
> pcbnew/dialogs/dialog_gendrill_base.h | 18 +-
> .../dialog_general_options_BoardEditor_base.cpp | 2 +-
> .../dialog_general_options_BoardEditor_base.fbp | 2 +-
> .../dialog_general_options_BoardEditor_base.h | 6 +-
> .../dialogs/dialog_get_footprint_by_name_base.cpp | 5 +-
> .../dialogs/dialog_get_footprint_by_name_base.fbp | 4 +-
> pcbnew/dialogs/dialog_get_footprint_by_name_base.h | 5 +-
> pcbnew/dialogs/dialog_global_deletion_base.cpp | 31 +-
> pcbnew/dialogs/dialog_global_deletion_base.fbp | 2 +-
> pcbnew/dialogs/dialog_global_deletion_base.h | 10 +-
> .../dialog_global_edit_tracks_and_vias_base.cpp | 2 +-
> .../dialog_global_edit_tracks_and_vias_base.fbp | 1456 ++++++++++----------
> .../dialog_global_edit_tracks_and_vias_base.h | 8 +-
> .../dialog_global_modules_fields_edition_base.cpp | 2 +-
> .../dialog_global_modules_fields_edition_base.fbp | 2 +-
> .../dialog_global_modules_fields_edition_base.h | 6 +-
> pcbnew/dialogs/dialog_global_pads_edition_base.cpp | 8 +-
> pcbnew/dialogs/dialog_global_pads_edition_base.fbp | 2 +-
> pcbnew/dialogs/dialog_global_pads_edition_base.h | 8 +-
> .../dialog_graphic_item_properties_base.cpp | 4 +-
> .../dialog_graphic_item_properties_base.fbp | 4 +-
> .../dialogs/dialog_graphic_item_properties_base.h | 5 +-
> .../dialog_graphic_item_properties_for_Modedit.cpp | 1 +
> .../dialogs/dialog_graphic_items_options_base.cpp | 2 +-
> .../dialogs/dialog_graphic_items_options_base.fbp | 2 +-
> pcbnew/dialogs/dialog_graphic_items_options_base.h | 8 +-
> .../dialog_keepout_area_properties_base.cpp | 2 +-
> .../dialog_keepout_area_properties_base.fbp | 2 +-
> .../dialogs/dialog_keepout_area_properties_base.h | 4 +-
> pcbnew/dialogs/dialog_layer_selection_base.cpp | 2 +-
> pcbnew/dialogs/dialog_layer_selection_base.fbp | 4 +-
> pcbnew/dialogs/dialog_layer_selection_base.h | 16 +-
> pcbnew/dialogs/dialog_layers_setup_base.cpp | 290 +++-
> pcbnew/dialogs/dialog_layers_setup_base.fbp | 2 +-
> pcbnew/dialogs/dialog_layers_setup_base.h | 16 +-
> pcbnew/dialogs/dialog_mask_clearance_base.cpp | 6 +-
> pcbnew/dialogs/dialog_mask_clearance_base.fbp | 2 +-
> pcbnew/dialogs/dialog_mask_clearance_base.h | 6 +-
> pcbnew/dialogs/dialog_modedit_options_base.cpp | 2 +-
> pcbnew/dialogs/dialog_modedit_options_base.fbp | 2 +-
> pcbnew/dialogs/dialog_modedit_options_base.h | 6 +-
> pcbnew/dialogs/dialog_move_exact.fbp | 4 +-
> pcbnew/dialogs/dialog_move_exact_base.cpp | 4 +-
> pcbnew/dialogs/dialog_move_exact_base.h | 11 +-
> pcbnew/dialogs/dialog_netlist_fbp.cpp | 2 +-
> pcbnew/dialogs/dialog_netlist_fbp.fbp | 2 +-
> pcbnew/dialogs/dialog_netlist_fbp.h | 20 +-
> .../dialog_non_copper_zones_properties_base.cpp | 7 +-
> .../dialog_non_copper_zones_properties_base.fbp | 2 +-
> .../dialog_non_copper_zones_properties_base.h | 6 +-
> pcbnew/dialogs/dialog_pad_properties_base.cpp | 2 +-
> pcbnew/dialogs/dialog_pad_properties_base.fbp | 2 +-
> pcbnew/dialogs/dialog_pad_properties_base.h | 18 +-
> pcbnew/dialogs/dialog_pcb_text_properties_base.cpp | 2 +-
> pcbnew/dialogs/dialog_pcb_text_properties_base.fbp | 2 +-
> pcbnew/dialogs/dialog_pcb_text_properties_base.h | 4 +-
> pcbnew/dialogs/dialog_plot_base.cpp | 4 +-
> pcbnew/dialogs/dialog_plot_base.fbp | 4 +-
> pcbnew/dialogs/dialog_plot_base.h | 23 +-
> .../dialog_pns_diff_pair_dimensions_base.cpp | 4 +-
> .../dialog_pns_diff_pair_dimensions_base.fbp | 4 +-
> .../dialogs/dialog_pns_diff_pair_dimensions_base.h | 7 +-
> .../dialog_pns_length_tuning_settings_base.cpp | 50 +-
> .../dialog_pns_length_tuning_settings_base.fbp | 2 +-
> .../dialog_pns_length_tuning_settings_base.h | 4 +-
> pcbnew/dialogs/dialog_pns_settings_base.cpp | 4 +-
> pcbnew/dialogs/dialog_pns_settings_base.fbp | 4 +-
> pcbnew/dialogs/dialog_pns_settings_base.h | 5 +-
> pcbnew/dialogs/dialog_print_for_modedit_base.cpp | 2 +-
> pcbnew/dialogs/dialog_print_for_modedit_base.fbp | 2 +-
> pcbnew/dialogs/dialog_print_for_modedit_base.h | 12 +-
> pcbnew/dialogs/dialog_print_using_printer_base.cpp | 2 +-
> pcbnew/dialogs/dialog_print_using_printer_base.fbp | 2 +-
> pcbnew/dialogs/dialog_print_using_printer_base.h | 16 +-
> pcbnew/dialogs/dialog_scripting_base.cpp | 3 +-
> pcbnew/dialogs/dialog_scripting_base.fbp | 2 +-
> pcbnew/dialogs/dialog_scripting_base.h | 4 +-
> .../dialogs/dialog_select_net_from_list_base.cpp | 2 +-
> .../dialogs/dialog_select_net_from_list_base.fbp | 2 +-
> pcbnew/dialogs/dialog_select_net_from_list_base.h | 6 +-
> pcbnew/dialogs/dialog_select_pretty_lib_base.cpp | 2 +-
> pcbnew/dialogs/dialog_select_pretty_lib_base.fbp | 2 +-
> pcbnew/dialogs/dialog_select_pretty_lib_base.h | 6 +-
> pcbnew/dialogs/dialog_set_grid_base.cpp | 6 +-
> pcbnew/dialogs/dialog_set_grid_base.fbp | 6 +-
> pcbnew/dialogs/dialog_set_grid_base.h | 8 +-
> pcbnew/dialogs/dialog_target_properties_base.cpp | 2 +-
> pcbnew/dialogs/dialog_target_properties_base.fbp | 2 +-
> pcbnew/dialogs/dialog_target_properties_base.h | 6 +-
> .../dialogs/dialog_track_via_properties_base.cpp | 11 +-
> .../dialogs/dialog_track_via_properties_base.fbp | 2 +-
> pcbnew/dialogs/dialog_track_via_properties_base.h | 14 +-
> pcbnew/dialogs/dialog_track_via_size_base.cpp | 2 +-
> pcbnew/dialogs/dialog_track_via_size_base.fbp | 2 +-
> pcbnew/dialogs/dialog_track_via_size_base.h | 8 +-
> pcbnew/dialogs/dialog_update_pcb.fbp | 2 +-
> pcbnew/dialogs/dialog_update_pcb_base.cpp | 2 +-
> pcbnew/dialogs/dialog_update_pcb_base.h | 8 +-
> .../wizard_3DShape_Libs_downloader_base.cpp | 4 +-
> .../wizard_3DShape_Libs_downloader_base.fbp | 4 +-
> .../dialogs/wizard_3DShape_Libs_downloader_base.h | 21 +-
> pcbnew/dialogs/wizard_add_fplib_base.cpp | 4 +-
> pcbnew/dialogs/wizard_add_fplib_base.fbp | 4 +-
> pcbnew/dialogs/wizard_add_fplib_base.h | 17 +-
> pcbnew/import_dxf/dialog_dxf_import.fbp | 2 +-
> pcbnew/import_dxf/dialog_dxf_import_base.cpp | 20 +-
> pcbnew/import_dxf/dialog_dxf_import_base.h | 10 +-
> pcbnew/sel_layer.cpp | 4 +-
> 343 files changed, 3430 insertions(+), 3300 deletions(-)
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References
