← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 00/14] RFC: Events in Dialogs

 

Hi jp,

On 13.10.2016 12:42, jp charras wrote:

> Many times, it was said these files must be *never* modified by hand.
> You perfectly know that, and why it was said.

> So, why are doing that?

These patches are not meant to go into the mainline project, just to
demonstrate how I went looking for unused events, so they have to be
human readable (but still apply cleanly).

That's why I split out any large mechanical changes into separate
patches -- when you read patches, just ignore the ones that are only
comment changes, but if you want to test whether the code still works,
they are there so you don't get any errors.

For actual code changes, we'd probably group the changes to several
related dialogs together in a single commit, and readability of the
patch becomes a secondary concern then.

   Simon

Attachment: signature.asc
Description: OpenPGP digital signature


References