kicad-developers team mailing list archive

Thread
Date

EDGE_MODULE and DRAWSEGMENT refactor

To: KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
From: Maciej Sumiński <maciej.suminski@xxxxxxx>
Date: Thu, 17 Nov 2016 09:38:38 +0100
Authentication-results: spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

Would it make sense to get rid of EDGE_MODULE class? As far as I can
tell, the only difference I see is that EDGE_MODULE stores coordinates
relative to its parent module.

Perhaps we could have only DRAWSEGMENT offering methods to access both
absolute and relative position, but the latter is relative to its parent
BOARD_ITEM, which could be either BOARD or MODULE? Similar refactoring
could be applied to TEXTE_MODULE and TEXTE_PCB.

What do you think? Do I miss anything unusual about these classes?

Regards,
Orson

Attachment: signature.asc
Description: OpenPGP digital signature