kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Better but there are still a few minor issues:

There are some inconsistent spacing issues which I've highlighted in the
attached image.

I don't think you should put the text to the left of the checkbox.  It
just look out of place.  I don't recall ever seeing this done before.
Now that you've remove the other sizer, there is plenty of room to put
the text to the right of the checkbox.

If you don't mind, I would prefer we don't use abbreviations like min.
and max.  I would rather spell out minimum and maximum since I don't
know how well abbreviations translate into other languages.

I'm also not convinced that changing the tab order makes sense.
Although I'm not totally opposed to it either.  Anyone else have any
thoughts on this.

Thanks,

Wayne

On 12/15/2016 4:50 PM, Oliver Walters wrote:
> Wayne,
> 
> I have made the changes as suggested - new patch attached.
> 
> Regards,
> 
> Oliver
> 
> On Wed, Dec 14, 2016 at 6:22 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     I finally got a chance to look at this patch.  I like the changes for
>     the most part.  The check box and static text before text edit control
>     strings should have sentence capitalization (not title capitalization)
>     per our ui policy.  I think moving the check boxes to the left would
>     improve the layout.  I also would consider getting rid of the "Track
>     Options:" wxStaticBoxSizer.  I don't think it makes a lot of sense to
>     group a single item.  Maybe use a single "Options" wxStaticBoxSizer for
>     all of the options.
> 
>     Cheers,
> 
>     Wayne
> 
>     On 11/30/2016 4:03 AM, Oliver Walters wrote:
>     > Hi All,
>     >
>     > This is a small patch that adds floating point validation to the
>     VIA and
>     > TRACK options in the Global Design Rules tab on the DRC dialog in
>     pcbnew.
>     >
>     > The validators also prevent negative values from being entered.
>     >
>     > I have also swapped the radio buttons for checkboxes, and
>     performed some
>     > slight rearranging. Toggling the "Allow Micro Vias" box changes the
>     > enable status of the micro via controls.
>     >
>     > Here is a screenshot:
>     > blob:http://imgur.com/62c32a26-c6f7-46bd-b437-2ad99fabf579
>     <http://imgur.com/62c32a26-c6f7-46bd-b437-2ad99fabf579>
>     >
>     > Patch is attached.
>     >
>     > Cheers,
>     > Oliver
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 
>

Attachment: drc-editor-dialog-fixes.png
Description: PNG image