kicad-developers team mailing list archive

[Miguel Angel Ajo Pelayo <majopela@xxxxxxxxxx>]

Sorry, I just found the email. Sorry for my delayed answer.

The code looks good to me, I believe it's a good change, it's not backwards
compatible with the older footprint wizards, but the changes to make them
compatible seem simple enough, and well documented.


If I had comments to make, it'd be why are we using uInteger, uEtc for
parameter types.

Could we use the python convention to have constants in upcase, and may be
se

INTEGER_PARAM, .... ETC_PARAM on the python side ?

this is more nitpicking than anything.


Nice work.


On Mon, Nov 14, 2016 at 8:33 PM, jp charras <jp.charras@xxxxxxxxxx> wrote:

> Le 10/10/2016 à 02:30, Oliver Walters a écrit :
> > Anyone have any comments on this? I have fixed many issues that were
> raised last time. If I can get
> > some feedback, we can progress towards merge.
> >
> > On Thu, Sep 29, 2016 at 6:18 PM, Oliver Walters <
> oliver.henry.walters@xxxxxxxxx
> > <mailto:oliver.henry.walters@xxxxxxxxx>> wrote:
> >
> >     Hi All,
> >
> >     I have improved upon the footprint wizards patch, taking suggestions
> into account.
> >
> >     patch file attached.
> >
> >     There is an in-depth discussion of the new
> >     format: https://github.com/KiCad/Footprint_Wizards/wiki
> >     <https://github.com/KiCad/Footprint_Wizards/wiki>
> >
> >     In particular, instructions on how to update old wizards to the new
> format:
> >
> >     https://github.com/KiCad/Footprint_Wizards/wiki/
> Updating-Older-Wizards
> >     <https://github.com/KiCad/Footprint_Wizards/wiki/
> Updating-Older-Wizards>
> >
> >     Cheers,
> >
> >     Oliver
>
> Hi Oliver,
>
> Sorry for the delay.
> The patch works fine for me.
> Be patient.
>
> The only drawback for me is the fact it breaks the compatibility with old
> wizards (not blocking).
> Just a decision to take.
>
>
> --
> Jean-Pierre CHARRAS
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>