kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 1/3/2017 10:08 AM, jp charras wrote:
> Le 03/01/2017 à 15:30, jp charras a écrit :
>> Le 03/01/2017 à 14:03, Miguel Angel Ajo Pelayo a écrit :
>>> Sorry, I just found the email. Sorry for my delayed answer.
>>>
>>> The code looks good to me, I believe it's a good change, it's not backwards compatible with the
>>> older footprint wizards, but the changes to make them compatible seem simple enough, and well
>>> documented.
>>>
>>>
>>> If I had comments to make, it'd be why are we using uInteger, uEtc for parameter types.
>>>
>>> Could we use the python convention to have constants in upcase, and may be se
>>>
>>> INTEGER_PARAM, .... ETC_PARAM on the python side ?
>>>
>>> this is more nitpicking than anything. 
>>>
>>>
>>> Nice work.
>>
>> I agree, and I am willing to commit this change (the API is better), but because it breaks the
>> compatibility (yes, the changes to make old wizards compatible is simple and documented) I need the
>> Wayne's opinion before committing the changes.
>>
>> Attached a patch against the lastest kicad version (the initial patch is not applicable to the
>> current kicad version).
>>
> 
> My previous patch is perhaps missing some changes. Here is the full patch.

It looks fine to me except for some coding policy issues ( missing
spaces between ( and ) and some trailing white space).  The only issue I
see is anyone using the python code in custom scripts may not be very
happy about the changes.  It would be nice to hear from the original
author about the changes.  If no one has any serious objections, then
feel free to commit the patch.

Cheers,

Wayne