kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #27081
Re: [PATCH] Pcbnew, plot dialog: grey out advanced net attributes if Gerber X2 is unchecked.
Looks good to me, I pushed it. Thank you for your contribution to KiCad.
It's easy for patches to slip through the cracks - in the future, don't
be afraid to bump a patch a bit sooner, say within a week or two.
Apologies for losing it.
On Wed, Jan 04, 2017 at 07:45:40PM +0000, Diego Herranz wrote:
> Hi,
>
> Did anyone have a chance to look at this?
>
> Many thanks.
>
> Regards,
> Diego
>
> On Tue, Nov 22, 2016 at 8:10 AM, Diego Herranz <
> diegoherranz@xxxxxxxxxxxxxxxx> wrote:
>
> >
> > m_useGerberNetAttributes is useless if m_useGerberX2Attributes is not
> > checked.
> > So disabled (greyed out) when Gerber X2 gets unchecked to make it clear to
> > the user.
> > ---
> > pcbnew/dialogs/dialog_plot.cpp | 20 ++++++++++++++++++++
> > pcbnew/dialogs/dialog_plot.h | 3 ++-
> > pcbnew/dialogs/dialog_plot_base.cpp | 4 +++-
> > pcbnew/dialogs/dialog_plot_base.fbp | 2 +-
> > pcbnew/dialogs/dialog_plot_base.h | 3 ++-
> > 5 files changed, 28 insertions(+), 4 deletions(-)
> >
> >
Follow ups
References