← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] mousewheelpan + ctrl = zooming

 

I tested the patches and both the legacy and GAL canvases appear to
behave the same way so if no one objects, I'm going to commit the changes.

In the future, please commit your changes and use git format-patch to
generate patches.  It makes my life easier.

On 1/16/2017 1:38 PM, Константин Барановский wrote:
> Thank you, Wayne, for your response. I'm attached the checked patches.
> 
> 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>>:
> 
>     You are not being ignored.  I can't speak for all of the lead developers
>     but I've been really busy so pretty much everyone has been getting
>     ignored by me.  It's not intentional, it's just the reality of my
>     current work load.
> 
>     Patch is giving me an unexpected eof with 3d_viewer-pan_step.patch.
> 
>     Did you address Bernhard's concern about the behavior of the GAL
>     canvases as well as the legacy canvas?  I don't remember seeing anything
>     but I may have missed it.
> 
>     On 1/16/2017 11:29 AM, Константин Барановский wrote:
>     > Hello. I'm sorry for disturbing you, but I'm not understand why my
>     > messages are ignored. Proposed feature not needed for no one, except me?
>     > Or I'm made something wrong? Please, give any comment.
>     >
>     > 2017-01-06 12:03 GMT+02:00 Константин Барановский
>     > <baranovskiykonstantin@xxxxxxxxx
>     <mailto:baranovskiykonstantin@xxxxxxxxx>
>     <mailto:baranovskiykonstantin@xxxxxxxxx
>     <mailto:baranovskiykonstantin@xxxxxxxxx>>>:
>     >
>     >     2016-11-23 0:22 GMT+02:00 Maciej Sumiński <maciej.suminski@xxxxxxx <mailto:maciej.suminski@xxxxxxx>
>     >     <mailto:maciej.suminski@xxxxxxx
>     <mailto:maciej.suminski@xxxxxxx>>>:
>     >
>     >         I could not apply the second patch, it gives me
>     "unexpected end
>     >         of file
>     >         in patch" error. Would you verify the file?
>     >
>     >
>     >      I downloaded both patches and checked them, they looks good
>     for me.
>     >     I do not got any problems or errors.
>     >
>     >
> 
> 


References