kicad-developers team mailing list archive

[Simon Wells <swel024@xxxxxxxxx>]

Due to still getting

pcbnew/CMakeFiles/_pcbnew.dir/build.make:125: warning: overriding
commands for target `pcbnew/pcbnew.py'
pcbnew/CMakeFiles/_pcbnew.dir/build.make:89: warning: ignoring old
commands for target `pcbnew/pcbnew.py'

warnings during build on osx i have been trying to work out what is
causing this issue and found that we have duplicated

COMMAND ${PYTHON_EXECUTABLE}
${CMAKE_SOURCE_DIR}/scripting/build_tools/fix_swig_imports.py
${CMAKE_CURRENT_BINARY_DIR}/pcbnew.py

once on line 412 and again on line 745 in pcbnew/CMakeLists.txt

one of these is in KICAD_SCRIPTING conditional and the other is in
KICAD_SCRIPTING_MODULES conditional, however as you can't have MODULES
without SCRIPTING they seem redundant however i don't understand
enough about the swig system to just delete it and provide a patch.

Are there any swigheads who understand enough to say whether removing

    add_custom_target( FixSwigImportsModuleScripting ALL
        COMMAND ${PYTHON_EXECUTABLE}
${CMAKE_SOURCE_DIR}/scripting/build_tools/fix_swig_imports.py
${CMAKE_CURRENT_BINARY_DIR}/pcbnew.py
        DEPENDS _pcbnew
        COMMENT "Fixing swig_import_helper in Kicad scripting modules"
        )

is a bad idea?

thanks

Simon