kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Merged. Thank you.

On Sun, Jan 22, 2017 at 06:32:52AM +0800, John Beard wrote:
> Hi,
> 
> There are a few accessors in D_PAD that could do with const qualifiers.
> 
> Also a few functions return non-POD objects by const value. This
> doesn't actually acheive anything, except forcing the compiler to
> forgo move operations and use copies instead, which is just less
> efficient. It doesn't actually convey any meaning about the data
> itself (the calling code is the one to decide if it wants to call its
> newly copied/moved object "const" or not). If the functions returned
> const ref or const pointer, then it would have meaning.
> 
> I didn't change them all, as some are overrides that are part of a
> larger inheriance hierarchy.
> 
> Cheers,
> 
> John