kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Hi John,

I have just merged your patch, thank you for your contribution.

Regards,
Orson

On 01/23/2017 02:11 AM, John Beard wrote:
> Hi,
> 
> This is a small patch to move PostCommandMenuEvent up to
> EDA_BASE_FRAME, from PCB_BASE_EDIT_FRAME.
> 
> This function has nothing intristic to PCB edit frames, it would apply
> to any frame. I'd like to use it for code that works in both Pcbnew
> and Cvpcb, which have EDA_BASE_FRAME as the first suitable common
> ancestor (KIWAY_PLAYER is first, but that's not really suitable for
> menu event code).
> 
> I'm submitting this ahead of the code that uses it, because it's
> logically separate and stands alone, and it touches common headers: if
> the make_unique patch goes in alongside, this will avoid a
> double-recompile for anyone pulling both at once!
> 
> Cheers,
> 
> John
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature