← Back to team overview

kicad-developers team mailing list archive

Re: Pad import/export/push and modedit mirror

 

@Orson, would you please take a look at this patch when you get a
chance.  They both look good to me.

I did see a few coding policy issues.  Mostly this:

+        if ( selection[0]->Type() == PCB_PAD_T )

which should be:

+        if( selection[0]->Type() == PCB_PAD_T )

@John, please clean these up and resubmit the patches when you get a chance.

Thanks,

Wayne

On 1/25/2017 2:39 AM, John Beard wrote:
> Sorry, attached the wrong version of the "import export" patch - this
> is the correct sequence.
> 
> On Wed, Jan 25, 2017 at 12:41 AM, John Beard <john.j.beard@xxxxxxxxx> wrote:
>> Hi,
>>
>> Here are two patches for outstanding GAL functionality: pad
>> import/export/push and modedit mirroring.
>>
>> Pad "push" is what I termed global edit, since I think that describes
>> the action of taking a reference and "pushing" it to a filtered subset
>> of other pads. I am happy to keep the old name too, if that's
>> preferred.
>>
>> I have implemented in a new PAD_TOOL GAL tool as I think there could
>> be more pad-only function in future that can all stick together in
>> there.
>>
>> Let me know if there are any suggestions!
>>
>> John
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp


Follow ups

References