← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Changed the 3d model previewer to use spinboxes

 

On 1/26/2017 10:04 AM, Mário Luzeiro wrote:
> My only concern was about if the float precision that was allowed to be edited in the actual edition mode.
> I gave a look on the patch and looks Kristoffer has some concerns about it, but I couldn't get a chance to test the patch to see if / how it was keeping the decimal places.
> 
> I like the idea of spin controls but does it allows you to "formal" insert (typing) manual the value?

I pretty sure you can still use manual value entry when spin buttons are
present.  If not, than I would not apply this patch.

> 
> Mario
> ________________________________________
> From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx] on behalf of Wayne Stambaugh [stambaughw@xxxxxxxxx]
> Sent: 26 January 2017 14:49
> To: kicad-developers@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes
> 
> If no one is opposed to adding spin controls to the 3D model selection
> dialog, I'll commit this patch when I get a chance.  I've never been
> convinced that using a spin control to change a floating point number is
> terribly useful but I'm guessing some users will prefer this over manual
> entry of calculated values used by old curmudgeons like me.
> 
> On 1/26/2017 6:11 AM, Kristoffer Ödmark wrote:
>> Hello!
>>
>> One thing that has always bothered me is that when aligning 3D models to
>> fit the footprint, one have to type the value and test, delete
>> characters and test again. Very minor issue, but it still bothers me.
>>
>> With a spinbox the values can be changed using the mouse only.
>>
>> attaching the patch for this minor change.
>>
>> - Kristoffer
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References