← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

 

2017-01-30 15:25 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:

> Thank you Alejandro.  The refactoring looks good and the unit tests are
> a nice touch.  Since this patch is rather large, it might be worthwhile
> pushing this to a new branch in you own development repo on launchpad so
> other devs can clone it or merge it into there own development repos.
>

I've pushed a polygon-refactor branch on my own repo, see [1].


> Developers, please review and test this patch as thoroughly as possible
> and give feedback to Alejandro.  Once we are comfortable that it is good
> to go, we can merge it into master.
>
> I probably wont get time to review it this week since I'm leaving for
> FOSDEM Thursday.  I will try to get to it as soon as possible after I
> get back.
>

Nice, thank you!

[1] https://git.launchpad.net/~agarciamontoro/kicad/

Follow ups

References