← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Changed the 3d model previewer to use spinboxes

 

Welcome to the joys of cross platform development. :)

On 1/31/2017 1:18 AM, Kristoffer Ödmark wrote:
> I will look into it, the difference in behavior between the oses is very
> strange. 
> 
> -Kristoffer
> 
> On Jan 31, 2017 2:30 AM, "Wayne Stambaugh" <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Manual entry now works on windows but you changed the behavior.
>     Currently, as you enter a number in the edit control, the changes update
>     instantly.  With your patch, you have to tab to the next control before
>     the change is made.  IMO, this is a step backwards from the current
>     behavior at least on windows.  I'm not sure I'm good with this
>     regression.  Anyone else have any thoughts on this.
> 
>     On 1/30/2017 1:20 PM, Kristoffer Ödmark wrote:
>     > Hello!
>     >
>     > The patch now works under windows, mac and linux.
>     >
>     > -Kristoffer
>     >
>     > On 2017-01-27 16:40, Wayne Stambaugh wrote:
>     >> This doesn't work on windows at all.  Changing any of the values
>     either
>     >> with the spin buttons or direct entry into the edit control does not
>     >> update 3D view of the model.  This issue will need to be resolved
>     before
>     >> the patch can be committed.
>     >>
>     >> On 1/27/2017 8:16 AM, Kristoffer Ödmark wrote:
>     >>> Glad to hear it!
>     >>>
>     >>> Also, I found that incrementing in steps of 10 for the rotations
>     misses
>     >>> 45 deegrees, so changed that to 5 and made it wrap around at 180 as
>     >>> well.
>     >>>
>     >>> Attaching that one!
>     >>>
>     >>>  -Kristoffer
>     >>>
>     >>> On 2017-01-27 13:47, Wayne Stambaugh wrote:
>     >>>> It's on my list for today.  It would be nice if an osx dev could
>     >>>> test it
>     >>>> before it's committed just in case there is some unexpected
>     behavior
>     >>>> on osx.
>     >>>>
>     >>>> On 1/27/2017 7:43 AM, Chris Pavlina wrote:
>     >>>>> Just tried this. It's REALLY nice to be able to nudge the
>     model around
>     >>>>> by turning the scroll wheel over the fields. <3
>     >>>>>
>     >>>>> Anyone test this on something other than Linux yet? I'd like
>     to see
>     >>>>> this
>     >>>>> merged.
>     >>>>>
>     >>>>> On Thu, Jan 26, 2017 at 05:24:17PM +0100, Kristoffer Ödmark wrote:
>     >>>>>> Yes, you can still manually change the values, I tried that.
>     >>>>>>
>     >>>>>> The only change I did to the code was to change the stepping
>     of the
>     >>>>>> offset
>     >>>>>> to 0.1mm instead of 1 in this patch. the best thing is that
>     you can
>     >>>>>> now use
>     >>>>>> the scrollwheel as well. Wich makes rotating stuff a breeze.
>     >>>>>>
>     >>>>>> - Kristoffer
>     >>>>>>
>     >>>>>> On 2017-01-26 17:09, Chris Pavlina wrote:
>     >>>>>>> On Thu, Jan 26, 2017 at 09:49:40AM -0500, Wayne Stambaugh wrote:
>     >>>>>>>> If no one is opposed to adding spin controls to the 3D model
>     >>>>>>>> selection
>     >>>>>>>> dialog, I'll commit this patch when I get a chance.  I've never
>     >>>>>>>> been
>     >>>>>>>> convinced that using a spin control to change a floating point
>     >>>>>>>> number is
>     >>>>>>>> terribly useful but I'm guessing some users will prefer
>     this over
>     >>>>>>>> manual
>     >>>>>>>> entry of calculated values used by old curmudgeons like me.
>     >>>>>>>
>     >>>>>>> I can see value in it. When you're moving around a 3D model, you
>     >>>>>>> don't
>     >>>>>>> want to type in a specific value, you want to move it until it's
>     >>>>>>> aligned. If the model is far off it can be hard to guess
>     what the
>     >>>>>>> offset
>     >>>>>>> should be like, so having a button to nudge it up and down
>     could be
>     >>>>>>> nice.
>     >>>>>>>
>     >>>>>>> Might want to hold off for a bit though as I think there was
>     talk
>     >>>>>>> about
>     >>>>>>> an updated patch in IRC, this might not be final
>     >>>>>>>
>     >>>>>>>>
>     >>>>>>>> On 1/26/2017 6:11 AM, Kristoffer Ödmark wrote:
>     >>>>>>>>> Hello!
>     >>>>>>>>>
>     >>>>>>>>> One thing that has always bothered me is that when aligning 3D
>     >>>>>>>>> models to
>     >>>>>>>>> fit the footprint, one have to type the value and test, delete
>     >>>>>>>>> characters and test again. Very minor issue, but it still
>     bothers
>     >>>>>>>>> me.
>     >>>>>>>>>
>     >>>>>>>>> With a spinbox the values can be changed using the mouse only.
>     >>>>>>>>>
>     >>>>>>>>> attaching the patch for this minor change.
>     >>>>>>>>>
>     >>>>>>>>> - Kristoffer
>     >>>>>>>>>
>     >>>>>>>>>
>     >>>>>>>>>
>     >>>>>>>>> _______________________________________________
>     >>>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >>>>>>>>>
>     >>>>>>>>
>     >>>>>>>> _______________________________________________
>     >>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>>>>>> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >>>>>>>
>     >>>>>>> _______________________________________________
>     >>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>>>>> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >>>>>>>
>     >>>>>
>     >>>>>
>     >>>>> _______________________________________________
>     >>>>> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>>> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >>>>>
>     >>>>
>     >>>>
>     >>>> _______________________________________________
>     >>>> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >>>> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >>>>
>     >>>
>     >>>
>     >>> _______________________________________________
>     >>> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >>> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >>>
>     >>
>     >>
>     >> _______________________________________________
>     >> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >>
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 


References