kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

On Tue, Jan 31, 2017 at 11:32:40PM +0800, John Beard wrote:
> Hi,
> 
> The attached patches add the "exchange footprints" command to the GAL edit tool.
> 
> This is 1 out of 3 parts of
> https://bugs.launchpad.net/kicad/+bug/1541460. I'm not sure how to put
> this as a commit comment exactly.

Generally I close the bug with a comment requesting the submitter open
several new bugs for each part of the combined report.

*glares at Wayne*

;)

> 
> This is implemented as two segments:
> 
> * Put the dialog/exchange FP code into pcbnew/dialogs directory (as a
> header/implementation pair) where it can be reached by bother
> pcbframe.cpp and GAL tools. This also makes it easier to remove legacy
> calling code in future. No change is made to the functionality of the
> dialog.
> * Add the tool to the GAL, calling the dialog as needed.
> 
> The third patch is optional, but tidies up a copy-pasted selection
> routine into a named function and adds a little commentary to a couple
> of related existing functions.
> 
> Cheers,
> 
> John