← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Changed the 3d model previewer to use spinboxes

 

I was also using cairo if that makes a difference

- Kristoffer

On 02/01/2017 02:32 PM, Wayne Stambaugh wrote:
I was using windows 7 when I tested this.  I will check my windows 10
box at home when I get a chance.

On 2/1/2017 8:02 AM, Kristoffer Ödmark wrote:
Can someone else confirm this? In my win 10 VM this was working if you
clicked the viewmodel window it would get focus back.

-Kristoffer

On 01/31/2017 10:41 PM, José Ignacio wrote:
Windows has always been sucky dealing with scrollwheel focus, on most
program you have to click before you can scroll.

On Tue, Jan 31, 2017 at 2:50 PM, Diogo Condeço <diogocondeco@xxxxxxxxx
<mailto:diogocondeco@xxxxxxxxx>> wrote:

    Just a side note... This is working 100% in macos... The focus is
    working just fine... on 3D preview it zooms in and out...

    On Tue, Jan 31, 2017 at 8:03 PM, Wayne Stambaugh
    <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>> wrote:

        Better but there is still a problem on windows.  Once an edit
        control
        has the mouse event focus, you can no longer use the mouse wheel
        to zoom
        the model preview pane.  Left button clicking or double-clicking
        in the
        3D model preview pane makes no difference.  On windows it's
pretty
        typical albeit annoying to left click in a window so it will
        receive the
        mouse events.  I have to click on the one of the isometric view
        buttons
        to restore the mouse wheel zoom of the model preview pane.  You
        could
        possibly use EVT_ENTER_WINDOW and EVT_LEAVE_WINDOW events to
provide
        hover focus for the edit controls but this could be rather
        challenging
        on windows.

        Other than that it seems reasonable.  I think some of the
increment
        sizes could be a bit smaller.  Perhaps 5° for angles and 0.02"
        for offsets.

        On 1/31/2017 8:03 AM, Kristoffer Ödmark wrote:
        > The real motivation for doing this was the functionality of the
        > scrollwheel. Which I got for free in the spinctrldouble, only
        in linux
        > though.
        >
        > But since the implementation of spinctrls was horrible on
        other os, I
        > stuck with the textctrl and instead catch the mouse events and
        also the
        > keyevents pgup/pgdown and subtract/add.
        >
        > I did not implement the arrowbuttons, but the increment
        functionality is
        > there if anyone wants/cares for the up/down arrowbuttons.
        >
        > tested on windows and linux.
        >
        > - Kristoffer
        >
        > On 2017-01-31 10:01, Mário Luzeiro wrote:
        >> Just and idea:
        >> What about, somehow, this could be implemented with a second
        pair of
        >> widgets?
        >> i.e: keep the line entries as before, and somehow, catching
        the scroll
        >> mouse events on that line entry.. and may add arrow buttons
        on the
        >> side, to work as a spinbox? :S
        >>
        >> My 2 cents,
        >> Mario Luzeiro
        >> ________________________________________
        >> From: Kicad-developers
        >> [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx
        <mailto:ua.pt@xxxxxxxxxxxxxxxxxxx>] on
        >> behalf of Wayne Stambaugh [stambaughw@xxxxxxxxx
        <mailto:stambaughw@xxxxxxxxx>]
        >> Sent: 31 January 2017 01:30
        >> To: kicad-developers@xxxxxxxxxxxxxxxxxxx
        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
        >> Subject: Re: [Kicad-developers] [PATCH] Changed the 3d model
        previewer
        >> to use spinboxes
        >>
        >> Manual entry now works on windows but you changed the
behavior.
        >> Currently, as you enter a number in the edit control, the
        changes update
        >> instantly.  With your patch, you have to tab to the next
        control before
        >> the change is made.  IMO, this is a step backwards from the
        current
        >> behavior at least on windows.  I'm not sure I'm good with this
        >> regression.  Anyone else have any thoughts on this.
        >>
        >> _______________________________________________
        >> Mailing list: https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
        >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
        >> Unsubscribe : https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
        >> More help   : https://help.launchpad.net/ListHelp
        <https://help.launchpad.net/ListHelp>
        >>
        >
        >
        > _______________________________________________
        > Mailing list: https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
        > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
        > Unsubscribe : https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
        > More help   : https://help.launchpad.net/ListHelp
        <https://help.launchpad.net/ListHelp>
        >

        _______________________________________________
        Mailing list: https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
        Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
        Unsubscribe : https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
        More help   : https://help.launchpad.net/ListHelp
        <https://help.launchpad.net/ListHelp>




    --
    Diogo Condeço

    _______________________________________________
    Mailing list: https://launchpad.net/~kicad-developers
    <https://launchpad.net/~kicad-developers>
    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
    Unsubscribe : https://launchpad.net/~kicad-developers
    <https://launchpad.net/~kicad-developers>
    More help   : https://help.launchpad.net/ListHelp
    <https://help.launchpad.net/ListHelp>




_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


--
 -Kristoffer


References