kicad-developers team mailing list archive

Thread
Date

Re: [PATCH] Fix arc selection over-enthusiastic bounding boxes

To: <kicad-developers@xxxxxxxxxxxxxxxxxxx>
From: Maciej Suminski <maciej.suminski@xxxxxxx>
Date: Tue, 7 Feb 2017 23:44:08 +0100
Authentication-results: spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
In-reply-to: <CAG1r56LLZ0aaiVv=qOMTLJ8WhMW3N31WAsKNEUpoanCfYNc4Lg@mail.gmail.com>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

Now I wonder why I kept it this way. The only problem I have noticed is
that the center edit point (the white squares used for dragging) of
capacitor arcs disappear in the footprint editor when the arc itself out
of view. Still, I consider it less erroneous behaviour than what we
previously had. I will fix it tomorrow. I pushed the patch, thank you!

Regards,
Orson

On 02/05/2017 01:34 PM, John Beard wrote:
> Hi,
> 
> Here is a patch to fix https://bugs.launchpad.net/kicad/+bug/1492734,
> where a small-angle arc has an unexpectedly large bounding box,
> causing odd selection behaviour.
> 
> The code was actually already there with a TODO on it - this patch
> basically just uses that and replaces the TODO with a comment (one
> more TODO down!)
> 
> Cheers,
> 
> John
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

References

[PATCH] Fix arc selection over-enthusiastic bounding boxes
From: John Beard, 2017-02-05