← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Delete whole tracks in GAL

 

Mm, it seems this also reverses it such that you have to use backspace
to delete a footprint whereas in that case the delete key should be
used.

2017-02-07 10:36 GMT+01:00 John Beard <john.j.beard@xxxxxxxxx>:
> The first of these patches has a mistake in the selection code, which
> used to clear the selection and replace it, and should now augment,
> not replace.
>
> Please use the attached patches instead.
>
> Thanks,
>
> John
>
> On Mon, Feb 6, 2017 at 12:37 AM, John Beard <john.j.beard@xxxxxxxxx> wrote:
>> Apparently those patches don't apply because the diff context lines
>> have a line of a different non-mainline patch in them (from the rotate
>> CCW patch).
>>
>> Hopefully, these will apply to the current master.
>>
>> On Sun, Feb 5, 2017 at 9:23 PM, John Beard <john.j.beard@xxxxxxxxx> wrote:
>>> Hi,
>>>
>>> These patches implement deletion of whole tracks (actually whole
>>> connections, it won't span an unrouted gap).
>>>
>>> Fixes: https://bugs.launchpad.net/kicad/+bug/1517213
>>>
>>> This in in two parts:
>>>
>>> * Expand the current connection/track/net selection to act on multiple
>>> selections, not just the first item in the selection list and refactor
>>> the core of the traversal code in each case.
>>> * Register the pre-existing "remove alternate" tool action, add a
>>> concept of "delete flags" to COMMON_TOOLS, and when triggered, use the
>>> flag to conditionally select whole tracks to delete.
>>>
>>> The idea of the flags is to allow flexible mappings of modified delete
>>> actions, in much the same way as modifier keys, but without having to
>>> commit to a hardcoded key for each flag, so the mappings can be more
>>> eaisly user defined.
>>>
>>> This patch also reverses the mappings of the delete and backspace
>>> keys, so that backspace is "normal remove" and "delete" is "remove
>>> alternate". This keeps the mapping the same between legacy and GAL, as
>>> per the LP issue. Other than tracks, this won't change anything else,
>>> as there is as yet no other effect to alt remove, which wasn't used
>>> until now.
>>>
>>> Cheers,
>>>
>>> John
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


Follow ups

References