← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] CCW Rotation in GAL

 

Hi John,

I am fine with TOOL_EVT_UTILS class, so your patch has just been
committed. Thank you!

Regards,
Orson

On 02/05/2017 01:30 PM, John Beard wrote:
> Hi,
> 
> Here is a patch for adding CCW rotation to the GAL canvas.
> 
> Possibly controversial is the new namespace in tool_action_utils.h for
> dumping generic free function helpers that act on TOOL_ACTIONS and on
> other classes in concert. I feel that this is a way to isolate the
> these routines, giving access to whichever GAL tool functions needed
> them, while emphasising that they act via public interfaces of the
> relevant classes, but I defer to the GAL wizards for comment!
> 
> Fixes: https://bugs.launchpad.net/kicad/+bug/1660731 (but it's more
> extensive than just that, as it adds bidirectional rotation to
> everywhere there is unidirectional rotation in GAL now).
> 
> Cheers,
> 
> John
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References