← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add duplicate zone onto layer tool

 

Hi Orson, Wayne

First, good videos at FOSDEM.

Duplicate zone as in OpenGL canvas or duplicate zone onto layer as in legacy canvas, deserves its own menu entry.

One of them is enough for me. I use this feature in almost every board. Sometimes I duplicate the zone into another layer, sometimes I duplicate the zone into the same layer, move the zone and change the net afterwards.

Only done once per design... if everything goes alright at the first attempt. Most times zones need resize and/or move corners.



What makes hard to work with OpenGL canvas for tracks and zones is the fact that their menu is not accessible from the track or zone tool, but from the arrow tool.

Or maybe I have not set the tools correctly.

Application: kicad
Version: no-vcs-found-7434~57~ubuntu14.04.1, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.35.0 OpenSSL/1.0.1f zlib/1.2.8 libidn/1.28 librtmp/2.3
Platform: Linux 3.16.0-77-generic x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.54.0
Curl: 7.35.0
KiCad - Compiler: GCC 4.8.4 with C++ ABI 1002
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_SCH_IO_MANAGER=OFF
                  KICAD_USE_OCE=ON


Regards,
Pedro.

El 09/02/17 a las 19:25, Maciej Suminski escribió:
Nope, we can have both. The only thing I am arguing against is having
redundant tools and cluttering the menus, but if you say it should stay,
then I am fine with that.

On 02/09/2017 07:15 PM, Wayne Stambaugh wrote:
Any reason why we cannot support both?

On 2/9/2017 1:09 PM, Maciej Suminski wrote:
I do not negate the location of the menu entry, which is very
appropriate if we want to keep it. What I am discussing is usefulness of
having a dedicated tool to duplicate a zone to another layer, while it
can be easily done using the Duplicate tool and then changing properties
of the duplicated zone.

Regards,
Orson

On 02/09/2017 06:39 PM, Wayne Stambaugh wrote:
Why is it an issue having a duplicate zone onto layer menu entry in the
zone context menu?  Isn't that the point of context menus?  I would
think duplicating a zone onto another layer is well within the context
of commands that can be performed on the current zone.  If not in the
zone context menu, where else would it be reasonable to put this command
where it makes sense and is discoverable?

On 2/9/2017 12:05 PM, Maciej Suminski wrote:
What are your use cases? It is likely I am missing something, and I do
not want to make decisions basing only on my preferences.

I agree it is a common thing to have a GND zone on both sides of a
board, so they could be created by drawing one zone and then duplicating
it to the other side. The thing is, such operation is usually done once
per design, but it always shows up in the menu.

I think it used be much more useful when there was no Duplication tool.
Now two operations (duplicate & edit properties) are replaced with
'duplicate zone onto layer', saving you maybe 2 clicks per design. I
wonder if this kind operation deserves its own menu entry.

Regards,
Orson

On 02/09/2017 05:10 PM, Marcos Chaparro wrote:
Just as sidenote, that is the zone feature I use the most :)

Regards


Marcos

On Thu, Feb 9, 2017 at 8:51 AM, Maciej Suminski <maciej.suminski@xxxxxxx>
wrote:

Hi,

I committed the patch just to remove any potential 'this is not
available in GAL' complaints, but IMHO this particular feature is
needless and clutters the menu.

The code itself is obviously fine, I am just considering the value of
having a dedicated menu entry for such operation, but we can discuss it
later.

Regards,
Orson

On 02/06/2017 05:08 PM, John Beard wrote:
Hi,

This patch adds a missing tool to GAL: duplicate zone onto layer.

It's accessed through the zones context menu and does the same as the
legacy mode version.

Cheers,

John



_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



References