kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 2/12/2017 5:37 AM, Simon Wells wrote:
> i am stuck on the below as i do not understand whats trying to be
> achieved doing this
> 
>  # For phase 1, copy _pcbnew.kiface to the python module. line onward
> (line 733ish)
> 
> until the end of the if, and its broken for me.

It should just be a copy of the _pcbnew.kiface to the python library
with the correct python extension for python to a folder where python
can find it.  I'm not sure what the file extension is or where the
python library install path is in osx.  I can check with Dick but I'm
pretty sure by looking at the patch that is what it does.

> 
> 
> also can we please formalize a policy in the CMakeLists.txt files that
> 
> do_this(
>     INDENTED_STUFFS_HERE
> )
> 
> specifically that the closing bracket there is place inline with the
> start of the line of the opening bracket and not
> 
> do_this(
>     INDENTED_STUFFS_HERE
>     )
> 
> i find its much easier to look at the former than the latter
> 
> 
> 
> On 10 February 2017 at 02:58, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>> Simon,
>>
>> Have you made any progress on this yet?  I would really like to get this
>> committed but I don't want to break osx builds.
>>
>> Thanks,
>>
>> Wayne
>>
>> On 2/2/2017 8:57 PM, Wayne Stambaugh wrote:
>>> Thanks Simon.  Please send a patch against Dicks work so I can commit
>>> this at the same time.  I don't want to break osx builds.
>>>
>>> Thanks,
>>>
>>> Wayne
>>>
>>> On 2/2/2017 7:28 PM, Simon Wells wrote:
>>>> its not good on osx, I will take a look over the weekend, There are a
>>>> few things i would like to change in that cmakelists, esspecially in
>>>> regards to OSX and the order of things/when things are done
>>>>
>>>> On 3 February 2017 at 07:28, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>>>> Did anyone of our osx devs get a chance to test this patch yet?  I would
>>>>> like to get it merged.  It saves a nice chunk of time from builds.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Wayne
>>>>>
>>>>> On 1/26/2017 11:42 AM, Wayne Stambaugh wrote:
>>>>>> Would one of our osx devs please test the attached patch?  Dick sent me
>>>>>> this patch to fix the long standing issue of building _pcbnew.kiface
>>>>>> twice.  It works fine on windows and linux but the fix requires copying
>>>>>> _pcbnew.kiface with the correct python extension and I'm not so sure
>>>>>> this isn't going to cause build issues on osx.  Please let me know what
>>>>>> I need to change if this patch doesn't work on osx.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Wayne
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp