kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #27876
Re: GerbView GAL port
-
To:
Jon Evans <jon@xxxxxxxxxxxxx>, KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx>
-
Date:
Wed, 15 Feb 2017 09:44:04 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<CA+qGbCBSRNGR6PoQc-iQub+ziaea_WPk43W=1wbQaSgmJ9T8mw@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
On 14.02.2017 19:38, Jon Evans wrote:
> Hi all,
>
> I want to get familiar with the GAL codebase, and it occurred to me that
> it might be fun to play with porting GerbView to GAL. I know it is on
> the 6.x roadmap, but it seemed to me that it would be mostly not
> dependent on any other changes that I see on the roadmap or have seen
> people talking about on the mailing list.
>
Hi Jon,
Many thanks for your involvement. I think working on a GAL port of
GerbView is a great idea, even though it's not planned (yet) for the
nearest release.
> - Is anyone currently working on this?
I don't think so.
>
> - If a GAL port is "feature-complete", is there any reason for the app
> to retain the legacy graphics code, or can it just provide OpenGL and
> Cairo backends? My impression is the only think keeping legacy canvas
> in pcbnew is feature differences between legacy and GAL, but I wanted to
> check if there are other reasons.
Except for printing mentioned by JP, there's no reason to keep legacy
drawing code. I'm quite sure, though, printing could be handled by
GAL-Cairo with some minor modifications.
>
> - In my first hour of looking at the code for this, it seems like the
> GAL code currently has some interdependence with pcbnew that needs to be
> straightened out before using GAL in other applications. For example,
> EDA_DRAW_PANEL_GAL depends on PCB_PAINTER, not a generic PAINTER. Is
> this an open problem for anyone to tackle, or does anyone actively have
> plans to refactor this?
It's an obvious mistake, EDA_DRAW_PANEL_GAL should depend on the base
PAINTER class, and the PCB_PAINTER should be created in the
PCB_DRAW_PANEL_GAL. Would you be able to fix this?
Cheers,
Tom
Follow ups
References