← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Move layer color settings from child class to base class RENDER_SETTINGS

 

Thanks Orson!

Actually the weird patch numbers were due to a mistake in my git
format-patch command, so nothing too mysterious :-)  But I will have some
things coming up for sure...

Best,
Jon

On Thu, Feb 16, 2017 at 11:41 AM, Maciej Sumiński <maciej.suminski@xxxxxxx>
wrote:

> Hi Jon,
>
> I have just pushed your both patches. Now you made me curious what else
> is there between 0001-Setup-painter and 0006-Move-layer-colors. Thank
> you very much!
>
> Regards,
> Orson
>
> On 02/16/2017 04:30 AM, Jon Evans wrote:
> > Hi all,
> >
> > This patch follows up on the one I sent earlier, to finish removing
> > dependency on pcbnew for the GAL draw panel.  Since layer color settings
> > will be useful in other applications, I moved them from
> PCB_RENDER_SETTINGS
> > up to RENDER_SETTINGS.  I left GetColor() in the pcb class for now, but
> if
> > I make progress on enabling GAL in GerbView it might become more obvious
> > how that should be refactored into the base class.
> >
> > Best,
> > Jon
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>

References