← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

 

Hi all,

Attached is a follow-up patch to the COLOR4D change above -- I reverted
from using wxColourPickerCtrl back to wxBitmapButton in the eeschema color
config, because I finally got my Windows 10 testing environment set up, and
found out that for some reason wxColourPickerCtrl looks really ugly in
Windows 10.

Best,
Jon

On Fri, Feb 10, 2017 at 8:43 PM, Jon Evans <jon@xxxxxxxxxxxxx> wrote:

> Hi all,
>
> Attached is a (rather large!) patch that changes the internal color
> representation to COLOR4D across the codebase (except for places that
> directly deal with wx, where wxColour is used).
>
> This patch also enables arbitrary color selection for schematic and symbol
> library editor, as well as pcbnew in the GAL canvas.  GerbView and pcbnew
> legacy canvas still use the old color picker.  Colors will be coerced into
> the legacy palette when switching from GAL to legacy, in a way that tries
> to preserve the hue and value.
>
> Colors are serialized to the settings in CSS format, because it supports
> alpha and represents color components the same way COLOR4D does (as
> floating-point values from 0 to 1)
>
> Tested on Linux.  Can't test on Windows or Mac yet, sorry.
> I realize this is a large changeset and might take a while to review, so
> just ping me if it stops applying on master and I'll update it.
>
> Best,
> Jon
>

Attachment: 0002-Revert-from-wxColourPickerCtrl-to-wxBitmapButton.patch
Description: Binary data


Follow ups

References