kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

On Sat, Feb 18, 2017 at 11:04:57PM +0100, Nick Østergaard wrote:
> Well, one thing is ofc to bring down the burden to make a comitter
> understand your patch. This is a small patch and probably easy to
> comprehend, for some people.
> 
> But I don't really understand what problem this patch tries to fix,
> this means that I can't not really help testing it on a potentially
> different platform.

wx border styles are being used that are incompatible with each other
and it's causing Yet Another Wx Resize Bug.

> 
> Well, waiting a week to poke is brobably fine for this sort of thing.
> 
> It is the responsibility of the contributor to nurse the patch. IMHO.

Yeah, since we don't have any better patch management system you're just
gonna have to bump in a week or so. Things do get lost.

I'll push this shortly, it's simple enough. Thank you.

> 
> 2017-02-18 22:31 GMT+01:00 Clemens Koller <cko@xxxxxxxxx>:
> > Hello mergers!
> >
> > I don't see my patch in master. It was neither merged nor commented.
> > How long are devs expect to wait until it's okay to bump it?
> > How can we make sure that no patches get lost on the way... especially when they are so subtle.
> >
> > Regards,
> >
> > Clemens
> >
> > On 2017-02-08 22:13, Clemens Koller wrote:
> >> wxNO_BORDER and wxSW_3D seem incompatible and the border flickers
> >> when the tree frame gets resized. Using KICAD_DEFAULT_DRAWFRAME_STYLE
> >> avoids this.
> >>
> >> Signed-off-by: Clemens Koller <cko@xxxxxxxxx>
> >>
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp