kicad-developers team mailing list archive

[Joseph Chen <joseph.chen59@xxxxxxxxx>]

The attached patch is a very trivial change for swapping an icon order 
inside eeschema's part editor.  This change will make the part editor to 
be consistent with the footprint editor's icon order.

The issue, no mater how trivial it may be to other user, is that when 
editing a part, you need to first do "Select working library" to start a 
new part, and the icon is currently on the SECOND of the icon bar at the 
top, WHILE when editing a new footprint, the icon of "Select active 
library" is on the FIRST of the icon bar.

This inconsistency always drives me crazy, and I like the order inside 
the footprint editor.

So I am submitting the patch.

--Joe Chen



>From 81588c284da7ffb0e17691dfa379eb0e9171e1f9 Mon Sep 17 00:00:00 2001
From: "Joseph Y. Chen" <joseph.chen59@xxxxxxxxx>
Date: Sun, 19 Feb 2017 22:50:23 -0700
Subject: [PATCH] Swapped part editor icon order to be consistant with
 footprint editor

Signed-off-by: Joseph Y. Chen <joseph.chen59@xxxxxxxxx>
---
 eeschema/tool_lib.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/eeschema/tool_lib.cpp b/eeschema/tool_lib.cpp
index 7f5a25c..acbe4b7 100644
--- a/eeschema/tool_lib.cpp
+++ b/eeschema/tool_lib.cpp
@@ -110,13 +110,13 @@ void LIB_EDIT_FRAME::ReCreateHToolbar()
                                       wxAUI_TB_DEFAULT_STYLE | wxAUI_TB_HORZ_LAYOUT );
 
     // Set up toolbar
+    m_mainToolBar->AddTool( ID_LIBEDIT_SELECT_CURRENT_LIB, wxEmptyString, KiBitmap( library_xpm ),
+                            _( "Select working library" ) );
+
     m_mainToolBar->AddTool( ID_LIBEDIT_SAVE_CURRENT_LIB, wxEmptyString,
                             KiBitmap( save_library_xpm ),
                             _( "Save current library to disk" ) );
 
-    m_mainToolBar->AddTool( ID_LIBEDIT_SELECT_CURRENT_LIB, wxEmptyString, KiBitmap( library_xpm ),
-                            _( "Select working library" ) );
-
     m_mainToolBar->AddTool( ID_LIBEDIT_DELETE_PART, wxEmptyString, KiBitmap( delete_xpm ),
                             _( "Delete component in current library" ) );
 
-- 
2.7.4