← Back to team overview

kicad-developers team mailing list archive

Re: Patch to compile _pcbnew.kiface only once

 

Did Dick have look at the log and patched patch that Simon replied with?

Any comments on it or?

Den 20/02/2017 19.32 skrev "Wayne Stambaugh" <stambaughw@xxxxxxxxx>:

> Simon,
>
> I'm going to commits Dick's original patch as soon as possible.  I want
> to know if you (or anyone else who can fix the osx part of this) will be
> available to fix the osx part of this before I commit it to minimize the
> amount of time we have broken builds for osx.
>
> Thanks,
>
> Wayne
>
> On 2/13/2017 9:24 AM, Simon Wells wrote:
> > Error copying file "_pcbnew.kiface" to "_pcbnew.so".
> >
> > attached is dicks patch with my changes
> >
> > On 14 February 2017 at 03:15, Wayne Stambaugh <stambaughw@xxxxxxxxx>
> wrote:
> >> On 2/12/2017 5:15 PM, Bernhard Stegmaier wrote:
> >>>
> >>>> On 12 Feb 2017, at 22:18, Wayne Stambaugh <stambaughw@xxxxxxxxx>
> wrote:
> >>>>
> >>>> On 2/12/2017 5:37 AM, Simon Wells wrote:
> >>>>> i am stuck on the below as i do not understand whats trying to be
> >>>>> achieved doing this
> >>>>>
> >>>>> # For phase 1, copy _pcbnew.kiface to the python module. line onward
> >>>>> (line 733ish)
> >>>>>
> >>>>> until the end of the if, and its broken for me.
> >>>>
> >>>> It should just be a copy of the _pcbnew.kiface to the python library
> >>>> with the correct python extension for python to a folder where python
> >>>> can find it.  I'm not sure what the file extension is or where the
> >>>> python library install path is in osx.  I can check with Dick but I'm
> >>>> pretty sure by looking at the patch that is what it does.
> >>>
> >>> Did this (I guess it is using pcbnew stuff from machines python
> installation, not the python form inside pcbnew) ever work on macOS?
> >>>
> >>> That doesn’t really make sense on macOS with application bundles
> (IMHO).
> >>> The install step is just an intermediate step to create the initial
> bundle on the build machine.
> >>> If you install it to some python folder on the build machine, it won’t
> get anywhere on a users machine when installing (== copying) the bundle
> (the bundle is not more than a folder, so you don’t really “install”
> anything).
> >>>
> >>> One thing would probably be to create an own installer/bundle for this
> python stuff, which puts things in the right places on the destination
> machine. I don’t know if this is easily possible, because you could have
> more than one python installed and I don’t know about paths in libs.
> >>> Or, put it inside the bundle and let user handle it on his own (by
> symlinking, whatever…).
> >>>
> >>> Same fun will come up on Linux with AppImage stuff (and the other
> similar approaches)…
> >>>
> >>>
> >>> Regards,
> >>> Bernhard
> >>>
> >>
> >> Please send me the build output for the build failure with this patch.
> >> Dick offered to try to resolve it but he needs the build log.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

References