← Back to team overview

kicad-developers team mailing list archive

Re: Patch to compile _pcbnew.kiface only once

 

On 2/20/2017 6:27 PM, Nick Østergaard wrote:
> 2017-02-20 23:48 GMT+01:00 Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx>:
>> Hi Wayne,
>>
>> if you really want to have this commited soon, I’d suggest to completely
>> disable KICAD_SCRIPTING_MODULES stuff on macOS.
>>
>> I just had a look at the KICAD_SCRIPTING_MODULES stuff as it is now and I
>> think it is broken anyway (back then when I changed the bundle stuff I just
>> took what was already there).
>> That’s just a guess, because I never used or tested it… so, if anybody did
>> and it really works now, please tell.
>>
>> I will try to have a look in my spare time, but I can’t promise that this
>> will happen any time soon.
>> I am very busy with non-KiCAD family things right now and there’s not a lot
>> of time left.
>>
>> As I said in my previous mail, I don’t think that this kind of scripting is
>> just a matter of copying some lib around.
>> There needs to be some concept/idea how to do this nicely (or, at least
>> somewhat user friendly) with app bundles.
>>
>> How is this done on Windows?
>> You also don’t have a global filesystem with one Python there where you just
>> copy it into the right place… where does the Windows installer put those
>> files and how do you use them from some installed Python? Are there issues
>> with library paths of the library dependencies that come with KiCAD when
>> used from an external Python?
>>
> 
> I am not aware of any issues with it on windows, but I don't really use windows.
> 
> People have requested to include pip with the windows install, and
> that is done now, so I assume that at least something works.
> 
> I am not sure if the user uses the shell inside pcbnew or calls the
> python bundled with the installer. The file system layout is basically
> as on linux, just inside the install destination folder.

Would something like this work on osx rather than trying to fit into an
existing python install?  It might prove to be more reliable.  At least
you would always have a known python build.

> 
>>
>> Regards,
>> Bernhard
>>
>> On 20 Feb 2017, at 21:50, Simon Wells <swel024@xxxxxxxxx> wrote:
>>
>> Hi Wayne,
>>
>> I have already sent my concerns and what i am stuck on and have had no
>> response so at this point i am unable to help sorry
>>
>> On 21 February 2017 at 07:28, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> Simon,
>>
>> I'm going to commits Dick's original patch as soon as possible.  I want
>> to know if you (or anyone else who can fix the osx part of this) will be
>> available to fix the osx part of this before I commit it to minimize the
>> amount of time we have broken builds for osx.
>>
>> Thanks,
>>
>> Wayne
>>
>> On 2/13/2017 9:24 AM, Simon Wells wrote:
>>
>> Error copying file "_pcbnew.kiface" to "_pcbnew.so".
>>
>> attached is dicks patch with my changes
>>
>> On 14 February 2017 at 03:15, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> On 2/12/2017 5:15 PM, Bernhard Stegmaier wrote:
>>
>>
>> On 12 Feb 2017, at 22:18, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> On 2/12/2017 5:37 AM, Simon Wells wrote:
>>
>> i am stuck on the below as i do not understand whats trying to be
>> achieved doing this
>>
>> # For phase 1, copy _pcbnew.kiface to the python module. line onward
>> (line 733ish)
>>
>> until the end of the if, and its broken for me.
>>
>>
>> It should just be a copy of the _pcbnew.kiface to the python library
>> with the correct python extension for python to a folder where python
>> can find it.  I'm not sure what the file extension is or where the
>> python library install path is in osx.  I can check with Dick but I'm
>> pretty sure by looking at the patch that is what it does.
>>
>>
>> Did this (I guess it is using pcbnew stuff from machines python
>> installation, not the python form inside pcbnew) ever work on macOS?
>>
>> That doesn’t really make sense on macOS with application bundles (IMHO).
>> The install step is just an intermediate step to create the initial bundle
>> on the build machine.
>> If you install it to some python folder on the build machine, it won’t get
>> anywhere on a users machine when installing (== copying) the bundle (the
>> bundle is not more than a folder, so you don’t really “install” anything).
>>
>> One thing would probably be to create an own installer/bundle for this
>> python stuff, which puts things in the right places on the destination
>> machine. I don’t know if this is easily possible, because you could have
>> more than one python installed and I don’t know about paths in libs.
>> Or, put it inside the bundle and let user handle it on his own (by
>> symlinking, whatever…).
>>
>> Same fun will come up on Linux with AppImage stuff (and the other similar
>> approaches)…
>>
>>
>> Regards,
>> Bernhard
>>
>>
>> Please send me the build output for the build failure with this patch.
>> Dick offered to try to resolve it but he needs the build log.
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 



Follow ups

References