← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Move bitmaps.h out of base_struct.h

 

I committed your patch to the master branch.  Thank you for your
contribution to KiCad.  Anything that reduces the build time of KiCad is
a good thing.

Cheers,

Wayne

On 2/20/2017 8:03 AM, John Beard wrote:
> Hi,
> 
> Here is a patch to prevent bitmaps.h being included by nearly every
> file in KiCad via base_struct.h.
> 
> Prior to this commit, simply touching bitmaps.h would require the
> recompilation of over 400 files for pcbnew alone, not counting the
> bitmap files themselves, which are fairly quick to build.
> 
> After this commit, only 166 files are rebuilt, for all targets, and 46
> for just pcbnew and its deps, which is a pretty handy speedup of just
> under 90% by file count!
> 
> Many of the new includes of bitmaps.h will disappear along with legacy
> which will further shrink the impact of touching bitmaps.h.
> 
> An additional benefit is that the icon list is now in its own header,
> which makes it easier to automate in future.
> 
> Cheers,
> 
> John
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References