kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #28024
Re: [PATCH] Move bitmaps.h out of base_struct.h
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Tue, 21 Feb 2017 11:54:00 -0500
-
In-reply-to:
<CAG1r56JtXpEknXyYCS+5oDiFj6=AMrcfp5c4y_YfTJvxCjJ5Cg@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1
I committed your patch to the master branch. Thank you for your
contribution to KiCad. Anything that reduces the build time of KiCad is
a good thing.
Cheers,
Wayne
On 2/20/2017 8:03 AM, John Beard wrote:
> Hi,
>
> Here is a patch to prevent bitmaps.h being included by nearly every
> file in KiCad via base_struct.h.
>
> Prior to this commit, simply touching bitmaps.h would require the
> recompilation of over 400 files for pcbnew alone, not counting the
> bitmap files themselves, which are fairly quick to build.
>
> After this commit, only 166 files are rebuilt, for all targets, and 46
> for just pcbnew and its deps, which is a pretty handy speedup of just
> under 90% by file count!
>
> Many of the new includes of bitmaps.h will disappear along with legacy
> which will further shrink the impact of touching bitmaps.h.
>
> An additional benefit is that the icon list is now in its own header,
> which makes it easier to automate in future.
>
> Cheers,
>
> John
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References