← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: fix for bug 1659027

 

Le 22/02/2017 à 09:10, Cirilo Bernardo a écrit :
> I have attached a patch to the bug report:
> 
> https://bugs.launchpad.net/kicad/+bug/1659027/comments/14
> 
> I have tested on Linux and Windows but more testing/comments
> appreciated.
> 
> Bugs fixed:
> 1. Rejection of 3D files with upper-case extensions in Windows
> 2. non-ASCII path bug in fileType() function of 3D plugin
> 3. non-ASCII path bugs in KiCad's 3D cache object
> 
> Notes:
> 
> * non-ASCII path bugs are likely present in the other
> 3D plugins (vrml, x3d, IDF) so I need to have a look at the
> code for those and fix the bugs.
> 
> * there is a fundamental non-ASCII path bug in OpenCascade
> and by extension OCE: on Windows OpenCascade/OCE do
> not provide a mechanism for opening files via Windows'
> _wfopen() function so only files with a pure ASCII path may
> be processed. Some posts on the web suggest that this bug
> has been fixed in the latest version of OpenCascade but I
> haven't had time to verify this. For the moment, in Windows
> only, we cannot use files which have any non-ASCII characters
> in the absolute path. Linux is not affected and I have no idea
> about OSX.
> 
> - Cirilo
> 

I committed you patch, which works fine.

About non-ASCII characters in .stp filenames, files containing ASCII8 chars are accepted.


-- 
Jean-Pierre CHARRAS


References