← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: fix for bug 1659027

 

Maurice, please reread the email. It was a bug that caused it to not
work with uppercase, this is not the desired behaivour.

2017-02-22 14:52 GMT+01:00 easyw <easyw@xxxxxxxxxxxx>:
> Hi Cirilo,
>>
>> 1. Rejection of 3D files with upper-case extensions in Windows
>
> reject 3D files with upper case in windows is not the best behavior imo...
> Many manufacturers are using Upper-case extension
> i.e.
> http://www.tensility.com/3dmodels/54-00011.STEP
> Wouldn't be easier accept lower and upper case instead?
> Windows is a case insensitive OS
>
> Maurice
>
>
> On 22-Feb-17 9:10 AM, Cirilo Bernardo wrote:
>>
>> I have attached a patch to the bug report:
>>
>> https://bugs.launchpad.net/kicad/+bug/1659027/comments/14
>>
>> I have tested on Linux and Windows but more testing/comments
>> appreciated.
>>
>> Bugs fixed:
>> 1. Rejection of 3D files with upper-case extensions in Windows
>> 2. non-ASCII path bug in fileType() function of 3D plugin
>> 3. non-ASCII path bugs in KiCad's 3D cache object
>>
>> Notes:
>>
>> * non-ASCII path bugs are likely present in the other
>> 3D plugins (vrml, x3d, IDF) so I need to have a look at the
>> code for those and fix the bugs.
>>
>> * there is a fundamental non-ASCII path bug in OpenCascade
>> and by extension OCE: on Windows OpenCascade/OCE do
>> not provide a mechanism for opening files via Windows'
>> _wfopen() function so only files with a pure ASCII path may
>> be processed. Some posts on the web suggest that this bug
>> has been fixed in the latest version of OpenCascade but I
>> haven't had time to verify this. For the moment, in Windows
>> only, we cannot use files which have any non-ASCII characters
>> in the absolute path. Linux is not affected and I have no idea
>> about OSX.
>>
>> - Cirilo
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References