kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #28070
Re: quick fix for legacy_plugin.cpp import of legacy sch files, Version: (2017-02-21 revision 8bed8af)-master, debug build
Le 22/02/2017 à 15:28, Wayne Stambaugh a écrit :
> This doesn't look correct to me. The original parser code for global
> and hierarchical labels both show parsing the "Italic" keyword (see
> eeschema/sch_text.cpp). @JP, does this make sense to you or am I
> missing something? @Lachlan, if you have a schematic that is not being
> properly parsed, please post it or a minimal example showing the bug.
No, the patch is incorrect for me.
It breaks the current behavior.
>
> On 2/21/2017 8:19 PM, Lachlan Audas wrote:
>> Bug: importing legacy sch file's fails on global labels, because
>> code checks for "~" or "italics" on global
>> labels, when they have no such option.
>>
>> Fix bypass's check for global labels
>> Lachlan
--
Jean-Pierre CHARRAS
Follow ups
References